[oe] xfce4-dev-tools (was [OE-core] [PATCH] hicolor-icon-theme 0.12: add BBCLASSEXTEND=native for xfce tools)

[Andreas Müller]

On Thursday, November 10, 2011 07:56:09 PM Andreas Müller wrote:
> On Thursday, November 10, 2011 02:38:33 PM you wrote:
> > Op 10 nov. 2011, om 14:20 heeft Richard Purdie het volgende geschreven:
> > > On Thu, 2011-11-10 at 13:44 +0100, Koen Kooi wrote:
> > >> Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>
> > >> ---
> > >> .../hicolor-icon-theme/hicolor-icon-theme_0.12.bb  |    2 ++
> > >> 1 files changed, 2 insertions(+), 0 deletions(-)
> > >> 
> > >> diff --git
> > >> a/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
> > >> b/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
> > >> index 759c9d8..aeb89c9 100644
> > >> --- a/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
> > >> +++ b/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
> > >> @@ -5,6 +5,8 @@ BUGTRACKER = "https://bugs.freedesktop.org/"
> > >> LICENSE = "GPLv2"
> > >> LIC_FILES_CHKSUM =
> > >> "file://COPYING;md5=f08a446809913fc9b3c718f0eaea0426"
> > >> 
> > >> +BBCLASSEXTEND = "native"
> > >> +
> > >> SECTION = "unknown"
> > >> inherit gnome allarch
> > > 
> > > This is interesting dilemma since this is an allarch recipe. What issue
> > > were you seeing to need this? Could we add the allarch sysroot
> > > directory to PATH to resolve this instead? We could add a PROVIDES
> > > "hicolor-icon-theme-native" too...
> > 
> > XFCE needs some native tools to run, one of which has hicolor-icon-theme
> > in its depends. Without this patch you can't build xfce. Andreas might
> > know more about this.
> 
> Up to this mail I did not notice any problem but the bad guy seems
> xfce4-dev- tools: Few xfce recipes depend on that and it contains only:
> 
> - m4 autoconf extensions
> - two shell scripts (don't know what they are for...)
After test build fails for xfce-git recipes I know what the scripts are for: 
some extension, the shipped autogen scripts insist on. So the native support for 
xfce4-dev-tools was not that bad I think. I will break the dependency to  
hicolor- icon-theme and have a test build with that...
> 
> By inheriting xfce, it inherits gtk-icon-cache which seems to depend on
> hicolor- icon-theme.
> 
> I don't remember what exactly my idea was, when adding native support on
> that.
> 
> Will make a change, build test it on fresh build dir and send a patch on
> meta-oe mailing list.
> 
> Apart from bad practice on xfce4-dev-tools: I wouldn't have expected
> trouble when a native recipe depends on an allarch one.
> 
> Andreas
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core