[oe] [PATCH] abiword: fix no-undefined param

[Khem Raj]

On Wed, Nov 23, 2011 at 2:34 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---
>  .../abiword/abiword/fix.no.undefined.param.patch   |   30 ++++++++++++++++++++
>  meta-gnome/recipes-gnome/abiword/abiword_2.8.6.bb  |    5 ++-
>  2 files changed, 34 insertions(+), 1 deletions(-)
>  create mode 100644 meta-gnome/recipes-gnome/abiword/abiword/fix.no.undefined.param.patch
>
> diff --git a/meta-gnome/recipes-gnome/abiword/abiword/fix.no.undefined.param.patch b/meta-gnome/recipes-gnome/abiword/abiword/fix.no.undefined.param.patch
> new file mode 100644
> index 0000000..954b50d
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/abiword/abiword/fix.no.undefined.param.patch
> @@ -0,0 +1,30 @@
> +diff -uNr abiword-2.8.6.orig/src/Makefile.am abiword-2.8.6/src/Makefile.am
> +--- abiword-2.8.6.orig/src/Makefile.am 2009-09-09 15:11:01.000000000 +0200
> ++++ abiword-2.8.6/src/Makefile.am      2011-11-23 09:06:06.000000000 +0100
> +@@ -44,7 +44,7 @@
> +
> + libabiword_2_8_la_LDFLAGS = \
> +       $(DEPS_LIBS) \
> +-      --no-undefined \
> ++      -no-undefined \
> +       -avoid-version \
> +       -export-dynamic
> +
> +@@ -107,7 +107,7 @@
> +
> + AbiWord_LDFLAGS = \
> +       $(DEPS_LIBS) \
> +-      --no-undefined \
> ++      -no-undefined \
> +       -avoid-version \
> +       -export-dynamic \
> +       -headerpad_max_install_names
> +@@ -129,7 +129,7 @@
> +
> + abiword_LDFLAGS = \
> +       $(platform_ldflags) \
> +-      --no-undefined      \
> ++      -no-undefined      \
> +       -avoid-version      \
> +       -export-dynamic
> +
> diff --git a/meta-gnome/recipes-gnome/abiword/abiword_2.8.6.bb b/meta-gnome/recipes-gnome/abiword/abiword_2.8.6.bb
> index 1746769..2d0ec97 100644
> --- a/meta-gnome/recipes-gnome/abiword/abiword_2.8.6.bb
> +++ b/meta-gnome/recipes-gnome/abiword/abiword_2.8.6.bb
> @@ -2,9 +2,12 @@ require abiword-2.5.inc
>  DEPENDS += " loudmouth libwmf-native gtkmathview asio"
>  RCONFLICTS_${PN} = "abiword-embedded"
>
> +PR = "r1"
> +
>  SRC_URI = "http://www.abisource.com/downloads/abiword/${PV}/source/abiword-${PV}.tar.gz;name=abiword \
>            file://autogen-common.sh \
> -           file://nodolt.patch"
> +           file://nodolt.patch \
> +           file://fix.no.undefined.param.patch"
>
>  LIC_FILES_CHKSUM = "file://COPYING;md5=ecd3ac329fca77e2d0e412bec38e1c20"
>

while the content of this patch is ok it would be nice to have patch
header e.g. is this patch needed upstream or is it
a backport and some history that you shared in other email would make
sense to have that as commit comment