[oe] [meta-oe][PATCH v3 0/2] pull request for twm and xclock recipes

[Anders Darander]

* Imran Mehmood <imran_mehmood at mentor.com> [111007 16:15]:
> On 10/03/2011 05:48 PM, Imran Mehmood wrote:
> > hi koen,

> > On 09/22/2011 11:57 AM, Koen Kooi wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1

> >> Op 22-09-11 08:31, Mehmood, Imran schreef:
> >>> From: Imran Mehmood<Imran_Mehmood at mentor.com>

> >>> The following changes since commit
> >>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: 
> >>> Adds
> >>> cvs version recipe (initial recipe)
> >> That isn't in meta-oe, so I can't pull your git tree. I'll grab the 
> >> patches
> >> from patchwork for now, but in the future please use a clean tree for 
> >> pull
> >> requests

> > Sorry for much delayed response I was busy with some other issues. I 
> > fixed the warning messages with xclock but before sending the patch 
> > again just wanted to clear a confusion regarding your response below.

> > I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to 
> > create-pull-request script with -r because I wanted to create pull 
> > request for all commits on my branch, made after this one. If its 
> > wrong whats the right way or thing to do? I mean

In order to make it easy for everyone to pull from your git tree, the
pull request should be based on a commit that is in the upstream git
tree.

In other words, the error/problem with your pull request was that you
had created a branch, then commit X-number of patches to that branch.
However, you only used the latest Y-patches (with Y being less than X)
in your pull-request.

A better approach would have been to create a new branch, cherry-pick
the Y-patches that you wanted to upstream into this new branch. And
finally, create a pull request for this new branch.

Cheers,
Anders

> >  what commit id should I pass to the script? Please explain a bit more 
> > in detail so that I can prepare next patch as per requirements.


-- 
Anders Darander
ChargeStorm AB / eStorm AB