[oe] [meta-oe][PATCH] ldconfig-native: Change the license field

Paul Menzel paulepanter at users.sourceforge.net
Sun Oct 9 22:11:45 UTC 2011


Am Freitag, den 07.10.2011, 10:39 -0700 schrieb Khem Raj:
> The license should be GPLv2+

Koen has already committed this in 2f04e069 [1].

I have to remarks.

1. Combining your commit summary and message to

    ldconfig-native Correct license field to GPLv2+

would be better next time. Especially if looking at the commit log with
`--format=oneline` or on the Web.

> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  .../recipes-core/eglibc/ldconfig-native_2.12.1.bb  |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb b/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
> index 00edb6e..2a93913 100644
> --- a/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
> +++ b/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "A standalone native ldconfig build"
>  
> -LICENSE = "GPLv2.1"
> +LICENSE = "GPLv2+"

[…]

2. Looking at the source headers of for example `cache.c`

           /* Copyright (C) 1999-2003,2005,2006,2007 Free Software Foundation, Inc.
           This file is part of the GNU C Library.
           Contributed by Andreas Jaeger <aj at suse.de>, 1999.
        
           This program is free software; you can redistribute it and/or modify
           it under the terms of the GNU General Public License as published
           by the Free Software Foundation; version 2 of the License, or
           (at your option) any later version.
        
           This program is distributed in the hope that it will be useful,
           but WITHOUT ANY WARRANTY; without even the implied warranty of
           MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
           GNU General Public License for more details.
        
           You should have received a copy of the GNU General Public License
           along with this program; if not, write to the Free Software Foundation,
           Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
        
the license is GPLv2+ as you changed it to. But in `readelflib.c` we have

           /* Copyright (C) 1999, 2000, 2001, 2002, 2007 Free Software Foundation, Inc.
           This file is part of the GNU C Library.
           Contributed by Andreas Jaeger <aj at suse.de>, 1999 and
        		  Jakub Jelinek <jakub at redhat.com>, 1999.
        
           The GNU C Library is free software; you can redistribute it and/or
           modify it under the terms of the GNU Lesser General Public
           License as published by the Free Software Foundation; either
           version 2.1 of the License, or (at your option) any later version.
        
           The GNU C Library is distributed in the hope that it will be useful,
           but WITHOUT ANY WARRANTY; without even the implied warranty of
           MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
           Lesser General Public License for more details.
        
           You should have received a copy of the GNU Lesser General Public
           License along with the GNU C Library; if not, write to the Free
           Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
           02111-1307 USA.  */
        
which is LGPLv2.1+. Also `dl-cache.c` has the `LGPLv2.1+` license header.

So should the field be changed to `LICENSE = "GPLv2+ LGPL"`?


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20111010/b5e77dbd/attachment-0002.sig>


More information about the Openembedded-devel mailing list