[oe] [meta-efl][meta-oe 05/12] id3lib: Import from openembedded classic

[Paul Menzel]

Dear Martin, dear Denis,


Am Samstag, den 29.10.2011, 12:29 +0200 schrieb Martin Jansa:
> From: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
> 
> Added LIC_FILES_CHKSUM, and fixed LICENSE
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>

NACK.

please add the version you import and the commit ID you import from.
This is all written in the guide lines [1]!

> ---
>  meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb
> 
> diff --git a/meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb b/meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb
> new file mode 100644
> index 0000000..9be4ffb
> --- /dev/null
> +++ b/meta-oe/recipes-multimedia/id3lib/id3lib_3.8.3.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "Library for interacting with ID3 tags."
> +SECTION = "libs/multimedia"
> +PRIORITY = "optional"
> +DEPENDS = "zlib"
> +LICENSE = "GPLv2+"

That is not correct [2], it is `LGPLv2+`. Additionally the header
ordering is not the standard. I thought migration to meta-oe was
supposed to be a chance to clean up the recipes.

> +LIC_FILES_CHKSUM = "files://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7"
> +PR = "r0"

According to Koen these are going away. Unfortunately these things are
discussed on oe-core instead of openembedded-devel as described in the
Wiki [3].

> +inherit autotools
> +
> +SRC_URI = "${SOURCEFORGE_MIRROR}/id3lib/id3lib-${PV}.tar.gz;name=archive \
> +           http://ftp.de.debian.org/debian/pool/main/i/id3lib3.8.3/id3lib3.8.3_3.8.3-7.2.diff.gz;name=patch \
> +          "
> +
> +SRC_URI[archive.md5sum] = "19f27ddd2dda4b2d26a559a4f0f402a7"
> +SRC_URI[archive.sha256sum] = "2749cc3c0cd7280b299518b1ddf5a5bcfe2d1100614519b68702230e26c7d079"
> +SRC_URI[patch.md5sum] = "805c0320a2efb21c40ce06fa13cd7c4b"
> +SRC_URI[patch.sha256sum] = "9f03b59ccc8826a5be55a3dcde2f889067d58bdc72bf846416a198c9b933704c"


Thanks,

Paul


[1] http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
[2] http://git.openembedded.org/openembedded/log/recipes/id3lib/id3lib_3.8.3.bb
[3] http://www.openembedded.org/wiki/Mailing_lists
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20111029/a66329f7/attachment-0002.sig>