[oe] [PATCH] Add support for mini-box.com picoSAM9G45 board

Wed Sep 14 10:13:27 UTC 2011

Dear Nicu,

Am Mittwoch, den 14.09.2011, 11:35 +0300 schrieb Nicu Pavel:

> I attached a patch to add support for picoSAM9G45 board
> (http://www.mini-box.com/pico-SAM9G45-X)
> 
> More information about this board and software support is available on
> the wiki here: http://arm.mini-box.com/index.php?title=Main_Page

thank you for your contribution.

> From 82f4c501dd63225cc37fec58a9c649ae9d542513 Mon Sep 17 00:00:00 2001
> From: Nicu Pavel <npavel at mini-box.com>
> Date: Wed, 14 Sep 2011 11:30:18 +0300
> Subject: [PATCH] Add support for mini-box.com picoSAM9G45 board

1. Unfortunately our policy [1] forbids out to commit your patch,
because you did not add your Signed-off-by line.

2. Also please add the information from your introduction to the commit
message.

3. The more information the better. Looking at your Wiki pages you seem
to use the Ȧngström distribution. Please add that too and probably it is
also good to know what you have tested (ports, graphics, …).

I guess when your patches are committed the image is exactly the same as
the one build by the instructions in your Wiki [3]?

> ---
>  conf/machine/picosam9.conf       |   13 +
>  recipes/linux/picosam9/defconfig | 1806 ++++++++++++++++++++++++++++++++++++++
>  recipes/linux/picosam9_git.bb    |   23 +
>  3 files changed, 1842 insertions(+), 0 deletions(-)
>  create mode 100644 conf/machine/picosam9.conf
>  create mode 100644 recipes/linux/picosam9/defconfig
>  create mode 100644 recipes/linux/picosam9_git.bb

4. Please split up your patch into two patches adding the Linux kernel
stuff first and then the machine. All the detailed description should go
into the second commit message. Take [2] as an example. The Linux kernel
commit message should contain what version this is based on and if you
have plans to update to newer versions or stay with 2.6.32.x.

> diff --git a/conf/machine/picosam9.conf b/conf/machine/picosam9.conf
> new file mode 100644
> index 0000000..71f2c84
> --- /dev/null
> +++ b/conf/machine/picosam9.conf
> @@ -0,0 +1,13 @@
> +#@TYPE: Machine
> +#@Name: pico-SAM9G45 (http://www.mini-box.com/pico-SAM9G45-X)
> +#@DESCRIPTION: Machine configuration for the picoSAM9G45 board with a at91sam9m10 processor
> +
> +TARGET_ARCH = "arm"
> +
> +PREFERRED_PROVIDER_virtual/kernel = "picosam9"
> +
> +PREFERRED_PROVIDER_xserver = "xserver-kdrive"
> +
> +MACHINE_FEATURES += "usbhost kernel26 apm vfat screen touchscreen ethernet wifi bluetooth"
> +
> +require conf/machine/include/tune-arm926ejs.inc
> diff --git a/recipes/linux/picosam9/defconfig b/recipes/linux/picosam9/defconfig
> new file mode 100644
> index 0000000..a816d93
> --- /dev/null
> +++ b/recipes/linux/picosam9/defconfig
> @@ -0,0 +1,1806 @@
> +#
> +# Automatically generated make config: don't edit
> +# Linux kernel version: 2.6.32.9
> +# Mon Aug 29 10:24:42 2011

[…]

> diff --git a/recipes/linux/picosam9_git.bb b/recipes/linux/picosam9_git.bb
> new file mode 100644
> index 0000000..37cacb5
> --- /dev/null
> +++ b/recipes/linux/picosam9_git.bb
> @@ -0,0 +1,23 @@
> +DESCRIPTION = "Kernel for picoSAM9 board (http://www.mini-box.com/pico-SAM9G45-X)"
> +AUTHOR = "Nicu Pavel <npavel at mini-box.com>"

The author field in this case would be reserved for the upstream author
which is Linus and co I guess. We do not have a maintainer field so
please remove that line. The home page and the commit log currently have
to be enough to find the correct person to contact.

> +HOMEPAGE = "http://arm.mini-box.com"
> +KV = "2.6.32"
> +SRCREV = "5d564f090ee99a0570a2cc912ebc30b65922f7bb"
> +PV = "${KV}+gitr${SRCREV}"
> +PR = "r7"

Please start with "r0".

> +
> +require linux.inc
> +
> +# For Angstrom and Android Eclair 

Please remove the trailing white space (`git diff --check`).

Please add to the commit message what these additional patches do and if
they are submitted upstream.

> +SRC_URI = "\
> +  git://gitorious.org/picopc-kernel/kernel.git;protocol=git;branch=minibox-picopc-2.6.32 \
> +  file://defconfig \
> +"
> +
> +S = "${WORKDIR}/git"
> +
> +COMPATIBLE_HOST = "arm.*-linux"
> +COMPATIBLE_MACHINE = "picosam9"
> +CMDLINE = "mem=128M at 0x20000000 mem=128M at 0x70000000 console=ttyS0,115200 root=/dev/mmcblk0p2 rw init=/init rootdelay=1 rootwait=1 loglevel=7 androidboot.hardware=picopc"

Please add a comment why especially the last four options are needed.

> +KERNEL_IMAGETYPE = "uImage"
> +ARM_KEEP_OABI = "1"
> -- 
> 1.7.1

Please resend with these comments addressed as [PATCH v2] [4].

Thanks again,

Paul

[1] http://www.openembedded.org/wiki/Commit_Policy
[2] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-August/034645.html
[3] http://arm.mini-box.com/index.php?title=Compiling_Angstrom_for_pico-SAM9G45
[4] http://openembedded.org/index.php?title=How_to_submit_a_patch_to_OpenEmbedded
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110914/591899f0/attachment-0002.sig>