[oe] [PATCH] eglibc-2.9: allow building with newer GNU make

[Paul Menzel]

Am Mittwoch, den 14.09.2011, 16:43 +0200 schrieb Steffen Sledz:
> On 14.09.2011 16:36, Paul Menzel wrote:
> >>>> The patch header is missing [1].
> >>>
> >>> Hmmm? After reading [1] i could not find what exactly is missing.
> >>
> >> Does the guidelines require that the patch files itself (make-3.82.patch in this case) need a header (in addition to the commit comment)?
> > 
> > Yes, that is correct.
> 
> It would be very helpful if [1] could be modified in a way that makes clear that it talk about to separate things: the commit message *and* the patch header.
> 
> This was totally unclear for me after reading it.

I remarked that too when the guide lines were reviewed. And it is
explained in the second paragraph in the guideline [1].

        This policy refers both to patches that are being applied by
        recipes as well as commit messages that are part of the source
        control system, usually git. A patch file needs a header in
        order to describe the specific changes that are made within that
        patch, while a commit message describes one or more changes to
        the overall project or system. Both the patch headers and commit
        messages require the same attention and basic details, however
        the purposes of the messages are slightly different. A commit
        message documents all of the changes made as part of a commit,
        while a patch header documents items specific to a single patch.
        In many cases the patch header can also be used as the commit
        message.

Any suggestions are welcome though. And (the lame response) it is a Wiki
so everybody can improve the document.


Thanks,

Paul


> [1] http://openembedded.org/index.php?title=Commit_Patch_Message_Guidelines
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110914/b0621049/attachment-0002.sig>