[oe] [PATCH v4] linux-libc-headers 2.6.24: backport arm/asm/hwcap.h from recent kernel

[Paul Menzel]

Dear Steffen,


unfortunately I still have something to add. :(

Am Donnerstag, den 15.09.2011, 09:55 +0200 schrieb Steffen Sledz:

1. Please do not use `recent` but write the correct version. In this
case it would be 2.6.26 (see below).

> Enables building of OpenJDK which uses HWCAP_THUMBEE that is not present
> in 2.6.24 headers and was introduced with
> 
>   commit 4baa9922430662431231ac637adedddbb0cfb2d7
>   Author: Russell King <rmk at dyn-67.arm.linux.org.uk>
>   Date:   Sat Aug 2 10:55:55 2008 +0100
> 
>       [ARM] move include/asm-arm to arch/arm/include/asm

2. Of course that is not correct and I asked that in my last response
why a move should introduce new code lines.

Using

        git log --follow 4baa9922430662431231ac637adedddbb0cfb2d7 -- arch/arm/include/asm/hwcap.h

I found the following commit

        commit d7f864be8323e5394040e2877594645b0e7da85d
        Author: Catalin Marinas <catalin.marinas at arm.com>
        Date:   Fri Apr 18 22:43:06 2008 +0100
        
            ARMv7: Add support for the ThumbEE state saving/restoring
            
            This patch adds the detection and handling of the ThumbEE extension on
            ARMv7 CPUs.
            
            Signed-off-by: Catalin Marinas <catalin.marinas at arm.com>

introduced in 2.6.26.

        $ git describe --contains
        d7f864be8323e5394040e2877594645b0e7da85d
        v2.6.26-rc1~1090^2~27

Please note that this commit contains not only the addition of
HWCAP_THUMBEE to the header but a lot more. So is OpenJDK doing
something incorrectly then? Does it detect the wrong architecture?

> Signed-off-by: Steffen Sledz <sledz at dresearch-fe.de>
> Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
> ---
>  .../arm-hwcap-add-new-entries.patch                |   26 ++++++++++++++++++++
>  .../linux-libc-headers_2.6.24.bb                   |    6 +++-
>  2 files changed, 30 insertions(+), 2 deletions(-)
>  create mode 100644 recipes/linux-libc-headers/linux-libc-headers-2.6.24/arm-hwcap-add-new-entries.patch

[…]

Please update the relevant parts and send it to the list again. You can
commit it the next day if nobody else objects.


Thanks,

Paul


PS: It is hard for reviewers to see what changed in your patch
iterations. For example between v3 and v4. Please add a short note below
the commit message and separate that with an additional `---`. `git am`
will not pick that comment up then.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110915/9772cda7/attachment-0002.sig>