[oe] [meta-oe][PATCH 02/10] vlc: drop depends not yet in meta-oe

Martin Jansa martin.jansa at gmail.com
Fri Sep 16 14:12:21 UTC 2011


On Fri, Sep 16, 2011 at 08:06:21AM -0600, Gary Thomas wrote:
> On 2011-09-16 07:56, Martin Jansa wrote:
> > Signed-off-by: Martin Jansa<Martin.Jansa at gmail.com>
> > ---
> >   meta-oe/recipes-multimedia/vlc/vlc.inc |    3 ++-
> >   1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta-oe/recipes-multimedia/vlc/vlc.inc b/meta-oe/recipes-multimedia/vlc/vlc.inc
> > index ce608dc..aecfb3a 100644
> > --- a/meta-oe/recipes-multimedia/vlc/vlc.inc
> > +++ b/meta-oe/recipes-multimedia/vlc/vlc.inc
> > @@ -4,7 +4,8 @@ LICENSE = "GPLv2"
> >   SECTION = "multimedia"
> >
> >   DEPENDS = "libfribidi libtool libgcrypt gst-plugins-bad virtual/libsdl qt4-x11-free dbus libxml2 gnutls tremor faad2 ffmpeg flac \
> > -           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad libid3tag liba52 mpeg2dec', d)}"
> > +"
> > +#           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad libid3tag liba52 mpeg2dec', d)}"
> >
> >   SRC_URI = "http://download.videolan.org/pub/videolan/vlc/${PV}/vlc-${PV}.tar.bz2"
> >
> 
> Is this such a good idea, given that bitbake support for commented continuation lines is deprecated?

This isn't comment in multiline variable and it doesn't even end with
backslash..

so such line is pretty safe and I hope that Joel will reply to my issues
with vlc.inc:
http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-September/034954.html
http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-September/034957.html

and fix it properly later..

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110916/9861871d/attachment-0002.sig>


More information about the Openembedded-devel mailing list