[oe] [meta-networking][PATCH] traceroute: Remove bashisms

Martin Jansa martin.jansa at gmail.com
Fri Dec 21 21:37:20 UTC 2012


On Fri, Dec 21, 2012 at 10:23 PM, Morgan Little
<morgan.little at windriver.com> wrote:
> Signed-off-by: Morgan Little <morgan.little at windriver.com>
> ---
>  meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb
> index 719d9fb..d855c67 100644
> --- a/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb
> +++ b/meta-networking/recipes-support/traceroute/traceroute_2.0.18.bb
> @@ -32,10 +32,8 @@ do_install() {
>
>      install -d ${D}${mandir}
>      install -p -m644 ${PN}/${PN}.8 ${D}${mandir}
> -    pushd ${D}${mandir}
> -    ln -s ${PN}.8 ${PN}6.8
> -    ln -s ${PN}.8 tcptraceroute.8
> -    popd
> +    ln -s ${D}${mandir}${PN}.8 ${D}${mandir}${PN}6.8
> +    ln -s ${D}${mandir}${PN}.8 ${D}${mandir}tcptraceroute.8

Thanks for quick reply and fix, but I think this should be:
> +    ln -s ${PN}.8 ${D}${mandir}/${PN}6.8
> +    ln -s ${PN}.8 ${D}${mandir}/tcptraceroute.8

${D} path won't be valid on target and missing slash after mandir

And is there something referencing those man pages with different
name? Or why are those symlinks provided?

Cheers,




More information about the Openembedded-devel mailing list