[oe] [meta-oe][v2] 00/22] systemd rework

[Martin Jansa]

On Thu, Feb 16, 2012 at 03:02:54AM +0100, Andreas Müller wrote:
> V1 -> V2:
> [2]  do not check configuration variables for cross and nativesdk
> [3]  rename systemd_package to systemd_generate_package_scripts
> [6]  parse unit files to determine the files to pack
> [7]  create warning if *-systemd package already rdepends
>      it's base package
> added in V2:
> [8]-[20] remove obsolet systemd code from recipes (these were used as
>      test cases)
> [21] dhcp-(relay) test case for multiple systemd packages
> [22] modified to start service

Whole series looks good to me sofar.

I'm not sure what's meant by this warning:
WARNING:
/OE/shr-core/meta-openembedded/meta-oe/recipes-connectivity/gateone/gateone_git.bb:
it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd
WARNING:
/OE/shr-core/meta-openembedded/meta-oe/recipes-devtools/cloud9/cloud9_0.5.1.bb:
it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd        

I guess we should
-SYSTEMD_PACKAGES = "${PN}"
+SYSTEMD_PACKAGES = "${PN}-systemd"
with this patchset too and add ${PN}-systemd to task which pulls gateone/cloud9.

And I'm not sure if this change is intentional:
http://git.shr-project.org/git/?p=buildhistory.git;a=commitdiff;h=3d27d7267406bd0fb2ea2a48b108dbb8bc7c128f#patch18

as xserver-nodm-init-systemd doesn't really need xserver-nodm-init, but
probably won't harm if xserver-nodm-init is used only to pull
xinit+xserver-common dependency.

Cheers,

> 
> The following tests were performed:
> * build from scratch with [1]-[7] / run test
> * build from scratch / apply patches / build -> check buildhistory diff
> * build from scratch w/o patches / build from scratch with patches -> check
>   buildhistory diff
> 
> Additional patches were prepared for other recipes inheriting systemd. These are
> not yet send because they move systemd support from ${PN} to ${PN}-systemd which
> currently needs modifications on tasks/images. I'd be happy if a common accepted
> solution would be suggested/implemented (image-feature?).
> 
> This patch series can be pulled from:
> git://gitorious.org/schnitzeltony-oe-meta/meta-openembedded-systemd.git branch systemd2
> 
> Andreas Müller (22):
>   systemd-systemctl-native: add multiple services support
>   systemd.bbclass: enhance checks for SYSTEMD_PACKAGES and
>     SYSTEMD_SERVICE
>   systemd.bbclass: cosmetics
>   systemd.bbclass: automatically create packages set in
>     SYSTEMD_PACKAGES
>   automatically install all *.service and *.socket supplied in recipe's
>     SRC_URI
>   systemd.bbclass: automatically extend FILES_* for systemd packages
>   systemd.bbclass: automatically extend RDEPENDS for *-systemd packages
>   connman: remove unneeded systemd code
>   dropbear: remove unneeded systemd code
>   openssh: remove unneeded systemd code
>   elsa: remove unneeded systemd code
>   cronie: remove unneeded systemd code
>   xserver-nodm-init: remove unneeded systemd code
>   atftp: remove unneeded systemd code
>   udisks: remove unneeded systemd code
>   rsyslog: remove unneeded systemd code
>   syslog-ng: remove unneeded systemd code
>   dhcp: remove unneeded systemd code
>   gpsd: remove unneeded systemd code
>   busybox: remove unneeded systemd code
>   dhcp: add native systemd support for dhcp-relay
>   gpsd: use ${PN}.service instead ${PN}.socket in SYSTEMD_SERVICE to
>     enable service
> 
>  meta-efl/recipes-efl/efl/elsa_svn.bb               |   11 +--
>  meta-oe/classes/systemd.bbclass                    |  165 ++++++++++++++++++--
>  .../connman/connman_0.78.bbappend                  |    7 +-
>  .../recipes-connectivity/dhcp/dhcp_4.2.0.bbappend  |   18 +--
>  .../dhcp/files/dhcrelay.service                    |   10 ++
>  .../openssh/openssh_5.9p1.bbappend                 |   14 +--
>  .../recipes-core/busybox/busybox_1.19.3.bbappend   |    8 +-
>  .../dropbear/dropbear_2011.54.bbappend             |   11 +--
>  .../systemd/systemd-systemctl-native/systemctl     |   75 +++++----
>  meta-oe/recipes-extended/atftp/atftp_0.7.bb        |   10 +-
>  .../recipes-extended/cronie/cronie_1.4.8.bbappend  |   12 +--
>  meta-oe/recipes-extended/rsyslog/rsyslog.inc       |    7 +-
>  .../xserver-nodm-init/xserver-nodm-init_2.0.bb     |   10 +-
>  meta-oe/recipes-navigation/gpsd/gpsd_2.96.bb       |   14 +--
>  meta-oe/recipes-support/syslog-ng/syslog-ng.inc    |    7 +-
>  meta-oe/recipes-support/udisks/udisks_1.0.4.bb     |    9 +-
>  16 files changed, 222 insertions(+), 166 deletions(-)
>  create mode 100644 meta-oe/recipes-connectivity/dhcp/files/dhcrelay.service
> 
> -- 
> 1.7.4.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20120216/7c98787d/attachment-0002.sig>