[oe] [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations

[Martin Jansa]

On Sat, Jan 07, 2012 at 08:41:51AM -0200, Otavio Salvador wrote:
> On Sat, Jan 7, 2012 at 06:05, Koen Kooi <koen at dominion.thruhere.net> wrote:
> 
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Op 07-01-12 00:55, Andrea Adami schreef:
> > > * delete patches meant for BSP layers * bump PR
> >
> > With a recipe like xserver-common I don't see a point in going all out BSP
> > on it. This patch just moves things to layers just for the sake of moving
> > it
> > to layers. I strongly suspect that applying this patch will be a net burden
> > on device maintainers instead of a gain.
> >
> 
> I agree this is going to be bad at first but those kind of improvements
> always cause some problems for a later gain. Dropping things that ought to
> be in BSP layers is a good thing but only after the "fix other layers" time
> window.
> 
> I think this is worth it however it might be better to instead port the
> needed changes to OE-Core and ask other layers to adopt x11-common allowing
> us to remove this later on. This makes the change easier and avoid some
> problems for users IMO.

This whole recipe has machine specific bits and removing those bits
only of some machines (in this case all from meta-smartphone BSPs)
doesn't improve that recipe.

So if you want to improve it, merge extra functionality (like
xinput-pointercal) to oe-core and drop this completely, but breaking
some machines doesn't make thinks better.

Instead of "fixing" it in meta-smartphone BSPs I would just copy whole
xserver-common back to meta-shr, because I don't have time now to fix it
properly and spending time on .bbappends is not worth it in this case.

Cheers,

JaMa, from daywork..ffs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20120107/adee4d0a/attachment-0002.sig>