[oe] [oe-commits] Andreas Müller : systemd.bbclass: add *-systemd packages to RRECOMMENDS

[Andreas Müller]

On Wed, Jul 18, 2012 at 2:31 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
> On Tue, Jul 17, 2012 at 11:23:43AM +0200, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Op 17-07-12 11:18, Martin Jansa schreef:
>> > On Tue, Jul 17, 2012 at 10:54:41AM +0200, Andreas Müller wrote:
>> >> On Mon, Jul 16, 2012 at 8:25 PM, Martin Jansa <martin.jansa at gmail.com>
>> >> wrote:
>> >>> On Mon, Jul 16, 2012 at 07:42:56AM +0000, git at git.openembedded.org
>> >>> wrote:
>> >>>> Module: meta-openembedded.git Branch: master Commit:
>> >>>> 264e5a44e1111f939b43c11bb9514a0b435918db URL:
>> >>>> http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db
>> >>>>
>> >>>>
>> >>>>
>> Author: Andreas Müller <schnitzeltony at googlemail.com>
>> >>>> Date:   Wed Jul 11 20:46:07 2012 +0200
>> >>>>
>> >>>> systemd.bbclass: add *-systemd packages to RRECOMMENDS
>> >>>
>> >>> This is a bit unfortunate e.g. when busybox is used in small chroot
>> >>> image. busybox pulls busybox-syslog, which now adds
>> >>> busybox-syslog-systemd and it ends with
>> >>> systemd/dbus/udev/shadow/pam/util-linux/kmod being added to
>> >>> previously small image, see:
>> >>>
>> >>> http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f
>> >>>
>> >>>
>> >>>
>> So it could be solved by image specific BAD_RECOMMENDATIONs or something
>> >>> like that, but by default it doesn't work very well in this
>> >>> use-case.
>> >>>
>> >>> Cheers,
>> >>>
>> >> I think the image specific BAD_RECOMMENDATION is not that easy to
>> >> implement and to handle by user. I am 'dreaming' of of a distro layer
>> >> blacklist. So in your case the distro could mask out whole
>> >> meta-systemd. Could you live with that?
>> >
>> > No, as the same distro is used to create full images with systemd and
>> > this chroot-image is just small initramfs for kernel (where
>> > systemd+friends is really not needed/expected).
>>
>> I think the easiest solution is to remove 'inherit systemd' from busybox.
>
> I have similar problem with gpsd/fso-gpsd and gpsd-systemd too.. On some
> devices I would like to include gpsd-systemd in image (e.g. with
> systemd-machine-units or through some machine specific task), but on
> others (e.g. om-gta02) I need only fso-gpsd.service to provide gpsd
> (gpsd-systemd locks gpsd port).
>
> So maybe I didn't understand Andreas right.. I can put all *-systemd
> packages to BAD_RECOMMENDATIONs and then include only needed in
> tasks/images like I did before..
>
Martin,

Correct me if I go wrong but I think you are mixing up two issues:

issue 1. busybox: automatic redepending drags in things you don't want.
issue 2. gpsd: If I understand you right: there are two services
shipped and auto-enabled and that is leading to a conflict.

My suggestions:
issue 1. Similar as Koen suggested but I would add an additional
variable - something like SYSTEMD_NO_RRECOMMENDS_{PN}. If this is set
to "1", the automatic rrecommends are not appended.
issue 2. The conflict could be resolved by SYSTEMD_AUTO_ENABLE = "disable".

Andreas