[oe] [PATCH 1/3] proj: add recipe

[Paul Menzel]

Dear Jan,


thank you for your patch.

Am Dienstag, den 06.03.2012, 11:36 +0100 schrieb Jan Luebbe:

Could you please add the version number to the commit summary?

How did you test this package?

> Signed-off-by: Jan Luebbe <jluebbe at debian.org>
> ---
>  meta-oe/recipes-navigation/proj/proj.inc      |   13 +++++++++++++
>  meta-oe/recipes-navigation/proj/proj_4.7.0.bb |    7 +++++++

There seems to be 4.9 in OE-Classic? Is that not usable?

>  2 files changed, 20 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-navigation/proj/proj.inc
>  create mode 100644 meta-oe/recipes-navigation/proj/proj_4.7.0.bb
> 
> diff --git a/meta-oe/recipes-navigation/proj/proj.inc b/meta-oe/recipes-navigation/proj/proj.inc
> new file mode 100644
> index 0000000..f6275d1
> --- /dev/null
> +++ b/meta-oe/recipes-navigation/proj/proj.inc
> @@ -0,0 +1,13 @@
> +DESCRIPTION = "PROJ.4 - Cartographic Projections Library"
> +HOMEPAGE = "http://trac.osgeo.org/proj/"
> +SECTION = "libs"
> +
> +INC_PR = "r0"
> +
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=74d9aaec5fa0cd734341e8c4dc91b608"
> +
> +SRC_URI = "http://download.osgeo.org/proj/proj-${PV}.tar.gz"
> +
> +inherit autotools pkgconfig
> +

Please no new line at the end.

> diff --git a/meta-oe/recipes-navigation/proj/proj_4.7.0.bb b/meta-oe/recipes-navigation/proj/proj_4.7.0.bb
> new file mode 100644
> index 0000000..8e4f901
> --- /dev/null
> +++ b/meta-oe/recipes-navigation/proj/proj_4.7.0.bb
> @@ -0,0 +1,7 @@
> +require proj.inc
> +
> +PR = "${INC_PR}.0"
> +
> +SRC_URI[md5sum] = "927d34623b52e0209ba2bfcca18fe8cd"
> +SRC_URI[sha256sum] = "fc5440002a496532bfaf423c28bdfaf9e26cc96c84ccefcdefde911efbd98986"
> +

Please no new line at the end.

Also you do not need a INC file, because in OE-Core and meta-oe we try
to only have one version included.

Some of the comments also apply to your other patches.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20120306/c0083d47/attachment-0002.sig>