[oe] [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict

[Paul Eggleton]

On Thursday 11 October 2012 11:01:33 Martin Jansa wrote:
> On Wed, Oct 10, 2012 at 10:42:52AM +0000, git at git.openembedded.org wrote:
> > Module: meta-openembedded.git
> > Branch: master
> > Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696
> > URL:   
> > http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f522
> > 80ea9b2f3d7b36ef248be5ba3e7c696
> > 
> > Author: Otavio Salvador <otavio at ossystems.com.br>
> > Date:   Sat Oct  6 20:18:30 2012 +0000
> > ...
> > 
> > -PACKAGES_DYNAMIC = "lib*"
> > +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"
> 
> Unfortunatelly this does not work, this regexp matches everything starting
> with 'lib', so it's only a bit more strict then old version which matched
> everything starting with 'li' :).
> 
> Please change it to:
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc)"
> or
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*"
> 
> ^ isn't used in any PACKAGES_DYNAMIC in oe-core, but it could make matching
> faster * is used wrong in all PACKAGES_DYNAMIC in oe-core (as in glob, but
> not regexp), so all those last '-' are optional

Are we going to fix this to actually be a glob or are we going to start 
treating it as a regex? Frankly I'd prefer to fix it to be a glob since that's 
what everyone has assumed it was since the beginning.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre