[oe] [meta-oe][PATCH] smartmontools: import from OE classic

[Philip Balister]

On 04/27/2013 04:24 AM, Paul Eggleton wrote:
> On Friday 26 April 2013 23:41:38 Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Op 26-04-13 22:39, Nicolas Dechesne schreef:
>>> Import smartmontools recipe from OE classic, and updated to upstream
>>> v5.40.
>>>
>>> Also added cosmetic changes in the recipe: INC_PR support and homepage.
>>>
>>> Signed-off-by: Nicolas Dechesne <nicolas.dechesne at linaro.org> ---
>>> meta-oe/recipes-support/smartmontools/smartmontools.inc     | 10
>>> ++++++++++ meta-oe/recipes-support/smartmontools/smartmontools_5.40.bb |
>>> 5 +++++ 2 files changed, 15 insertions(+) create mode 100644
>>> meta-oe/recipes-support/smartmontools/smartmontools.inc create mode
>>> 100644 meta-oe/recipes-support/smartmontools/smartmontools_5.40.bb
>>>
>>> diff --git a/meta-oe/recipes-support/smartmontools/smartmontools.inc
>>> b/meta-oe/recipes-support/smartmontools/smartmontools.inc new file mode
>>> 100644 index 0000000..6f23055 --- /dev/null +++
>>> b/meta-oe/recipes-support/smartmontools/smartmontools.inc @@ -0,0 +1,10
>>> @@ +SECTION = "console/utils" +DESCRIPTION = "Control and monitor storage
>>> systems using S.M.A.R.T." +HOMEPAGE =
>>> "http://smartmontools.sourceforge.net/" +LICENSE = "GPLv2"
>>> +LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f" +INC_PR = "r1"
>>
>> Drop that
> 
> It would help for the sake of the uninitiated if you specified what to drop, 
> since your mail client has wrapped the quoted text incorrectly.
> 
>>> + +SRC_URI =
>>> "${SOURCEFORGE_MIRROR}/smartmontools/smartmontools-${PV}.tar.gz" +
>>> +inherit autotools diff --git
>>> a/meta-oe/recipes-support/smartmontools/smartmontools_5.40.bb
>>> b/meta-oe/recipes-support/smartmontools/smartmontools_5.40.bb new file
>>> mode 100644 index 0000000..93dc4db --- /dev/null +++
>>> b/meta-oe/recipes-support/smartmontools/smartmontools_5.40.bb @@ -0,0
>>> +1,5 @@ +require smartmontools.inc +PR = "${INC_PR}.1"
>>
>> And drop that.
>>
>> And do you really need a .inc?
> 
> Are we removing inc files if they were present in OE Classic? First I've heard 
> if we are...

If we are trying to reduce the number of versions of recipes we carry,
dropping .inc files would seem to be a good idea. I don't have strong
feelings, but it seems like something we should consider.

Philip