[oe] [meta-oe][PATCH v2] lvm2: Add dependency on bash

[Prica, Mihai]

>-----Original Message-----
>From: openembedded-devel-bounces at lists.openembedded.org
>[mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
>Prica, Mihai
>> -----Original Message-----
>> From: Paul Eggleton [mailto:paul.eggleton at linux.intel.com]
>>
>> On Friday 26 July 2013 19:43:45 Martin Jansa wrote:
>> > On Fri, Jul 26, 2013 at 05:25:29PM +0300, Mihai Prica wrote:
>> > > Fixes rootfs generation error if bash is not included in the image.
>> >
>> > With rpm right?
>>
>> If it's what you're suggesting technically it's broken with any
>> package backend, to some degree.
>
>For the tests I used rpm.
>
>>
>> > Find which script it has in shebang and add bash only to that
>> > package RDEPENDS, if it's something which isn't always needed put it
>> > in separate package.

>From what I discovered, the scripts in question provide some of the core functionality
for the package so there is no point in splitting them.

>>
>> Or if practical patch the script(s) to remove the bashisms and change
>> the shebang to #!/bin/sh instead.
>
>I've looked over the scripts and there seem to be 4 files which are using bash. The
>files are part of the core lvm2 package. I've used checkbashism and there are not
>many changes that need to be done to switch to /bin/sh. I'll send an updated
>patch.

I've taken a deeper look into the problem and it seems there are some specific 
bashisms that are hard to replace and that might break the functionality. 

I've sent an updated patch changing the DEPENDS to an RDEPENDS.

Thanks,
Mihai

>
>Thanks,
>Mihai
>
>>
>> Cheers,
>> Paul
>>
>> --
>>
>> Paul Eggleton
>> Intel Open Source Technology Centre
>_______________________________________________
>Openembedded-devel mailing list
>Openembedded-devel at lists.openembedded.org
>http://lists.openembedded.org/mailman/listinfo/openembedded-devel