[oe] Check in Request for WIND00398740 : autofs_5.0.7 do_compile failed with the msg "#error Failed to locate modprobe
Joe MacDonald
Joe.MacDonald at windriver.com
Thu Jan 17 14:04:30 UTC 2013
[Check in Request for WIND00398740 : autofs_5.0.7 do_compile failed with the msg "#error Failed to locate modprobe] On 13.01.17 (Thu 10:34) yzhu1 wrote:
> Hi, JoeM
>
> GK && TK is OK.
>
> Please check it this patch. The patch is in the attachment. Please check it.
>
> Thanks a lot.
> Zhu Yanjun
Hi Yanjun,
There's a few hiccups with this one.
- the patch appears to be against meta-networking, not
meta-openembedded. I can work with that, but nothing should be
committed to meta-networking, that's purely my own side-project and
everything going to it needs to come through commits in
meta-openembedded.
- the commit log includes a reference to an internal bug tracking
ID, that won't mean anything to anyone outside of Wind River (or to
most inside :-)).
- you copied an internal WR mailing list on this, which I think ends
up with bounces to anyone who replies and isn't inside WR.
- you should try to ensure your patches follow the OE guidelines, in
particular with an upstream-status line, not all patches in the
tree have them, but it's nice if we can stay on top of them.
- the submission didn't follow the standard guidelines for patches.
There's a recipe in the meta-networking layer (it's basically the same
as all the other meta-openembedded layers) that describes how to easily
send patches to the list in a way that ensures the machinery recognizes
it and that anyone can work with it. It's here:
meta-openembedded/
meta-networking/
MAINTAINERS
Something like this will help next time around:
git send-email -1 \
--to openembedded-devel at lists.openembedded.org \
--subject-prefix=meta-networking][PATCH
Since this is a straight back-port of an upstream patch, I don't expect
it to be a big deal, so I've updated your commit log and the patch
header with the information from the link you quoted above. Mainly just
FYI for the next time.
Thanks.
--
-Joe MacDonald.
:wq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20130117/bd280098/attachment-0002.sig>
More information about the Openembedded-devel
mailing list