[oe] [meta-networking][PATCH] dnsmasq: install .service only with systemd in DISTRO_FEATURES

[Joe MacDonald]

[Re: [oe] [meta-networking][PATCH] dnsmasq: install .service only with systemd in DISTRO_FEATURES] On 13.07.04 (Thu 11:50) Paul Eggleton wrote:

> On Thursday 04 July 2013 17:26:23 Chunrong Guo wrote:
> > Signed-off-by: Chunrong Guo <B40290 at freescale.com>
> > ---
> >  .../recipes-support/dnsmasq/dnsmasq.inc            |    8 +++++---
> >  1 files changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/meta-networking/recipes-support/dnsmasq/dnsmasq.inc
> > b/meta-networking/recipes-support/dnsmasq/dnsmasq.inc index
> > 0f5b273..0710893 100644
> > --- a/meta-networking/recipes-support/dnsmasq/dnsmasq.inc
> > +++ b/meta-networking/recipes-support/dnsmasq/dnsmasq.inc
> > @@ -30,9 +30,11 @@ do_install () {
> >      install -d ${D}${sysconfdir}/ ${D}${sysconfdir}/init.d
> > ${D}${sysconfdir}/dnsmasq.d install -m 644 ${WORKDIR}/dnsmasq.conf
> > ${D}${sysconfdir}/
> >      install -m 755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/dnsmasq
> > -
> > -    install -d ${D}${systemd_unitdir}/system
> > -    install -m 0644 ${WORKDIR}/dnsmasq.service
> > ${D}${systemd_unitdir}/system +
> > +    if ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)};
> > then +        install -d ${D}${systemd_unitdir}/system
> > +        install -m 0644 ${WORKDIR}/dnsmasq.service
> > ${D}${systemd_unitdir}/system +    fi
> > 
> >      if [ "${@base_contains('PACKAGECONFIG', 'dbus', 'dbus', '', d)}" != ""
> > ]; then install -d ${D}${sysconfdir}/dbus-1/system.d
> 
> I think we should really have a global fix for this issue rather than hacking 
> up every recipe:
> 
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=4309

I'm inclined to agree, but looking at the bug it looks like the
potential solution was discussed in February and it's on the schedule
for Yocto 1.5, but that's October.

So I did a quick survey, here's the meta-networking recipes that'll be
impacted, if we adopt the workaround approach:

   - net-snmp
   - dnsmasq (obviously)
   - ypbind-mt
   - yp-tools
   - ntp
   - atftp

I decided I'd have a look at meta-oe for contrast (and guidance) and
this is what I found there:

   - slim
   - tracker
   - cloud9
   - zram
   - gpsd
   - gateone

On the other hand, xinput-calibrator and xserver-nodm-init,  already
have the same fix in it Chunrong is proposing.  So the impact of doing
either isn't huge, but it's not small either.

Chunrong:  Would you be willing to retest and resubmit your patch with
the above listed meta-networking recipes as a set?  I don't see a lot of
sense in doing this piecemeal, I'm okay with taking a workaround until
#4309 gets fixed, but I'd rather tear the band-aid off all at once, so
to speak.

-- 
-Joe MacDonald.
:wq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20130704/8ac2363c/attachment-0002.sig>