[oe] [meta-oe][PATCH v2] samba: remove /var/lock and /var/run from package

Khem Raj raj.khem at gmail.com
Mon Jul 8 13:52:03 UTC 2013


On Monday, July 8, 2013, Jonathan Liu <net147 at gmail.com> wrote:
> On 8 July 2013 15:53, Khem Raj <raj.khem at gmail.com> wrote:
>>
>> On Jul 7, 2013, at 10:37 PM, Jonathan Liu <net147 at gmail.com> wrote:
>>
>>> The /var/lock and /var/run directories are already created by
>>> base-files.
>>>
>>> Signed-off-by: Jonathan Liu <net147 at gmail.com>
>>> ---
>>> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bbb/meta-oe/recipes-connectivity/samba/
samba_3.6.8.bb
>>> index a27a28c..255c0b4 100644
>>> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>>> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>>> @@ -57,3 +57,9 @@ do_configure() {
>>> do_compile () {
>>>     base_do_compile
>>> }
>>> +
>>> +do_install_append() {
>>> +    rmdir "${D}${localstatedir}/lock"
>>> +    rmdir "${D}${localstatedir}/run"
>>> +    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
>>
>> what is this last rmdir doing ?
> It will remove the /var directory only if it is empty. In case there
> is nothing else in /var it's useless to have an empty /var directory.
>

Good. Mention it in commit message

> Regards,
> Jonathan
>
>>
>>
>>> +}
>>> --
>>> 1.8.3.2
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



More information about the Openembedded-devel mailing list