[oe] [PATCH] libhugetlbfs: add support for armv7a

[Anders Roxell]

On 2013-10-28 18:42, Khem Raj wrote:
> On Fri, Oct 18, 2013 at 7:09 AM, Anders Roxell <anders.roxell at linaro.org> wrote:
> > Signed-off-by: Anders Roxell <anders.roxell at linaro.org>
> > ---
> >  meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > index 24480c3..4f1bfa4 100644
> > --- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > +++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > @@ -20,10 +20,16 @@ SRC_URI = "git://git.code.sf.net/p/libhugetlbfs/code \
> >
> >  S = "${WORKDIR}/git"
> >
> > -COMPATIBLE_HOST = "(x86_64|powerpc|powerpc64|aarch64).*-linux*"
> > +COMPATIBLE_HOST = "(x86_64|powerpc|powerpc64|arm|aarch64).*-linux*"
> >
> > +python __anonymous() {
> > +    if base_contains('TARGET_ARCH', 'arm', True, False, d):
> > +        d.setVar('ARCH', 'armv7l')
> > +    else:
> > +        d.setVar('ARCH', d.getVar('TARGET_ARCH'))
> > +}
I'm sorry for the late response.

> 
> instead of this fugly anon python you could do
> 
> ARCH_arm = "armv7l"
> ARCH ?=  "${TARGET_ARCH}"
Much better, thanks!

> 
> and btw. we support ARM v4,v5,v6 architectures as well. It seems your
> patch only cares about armv7,
> and if this recipe only works for armv7+ then dont open the floodgates
> for all kind of arm architectures.
Agree.

Will send out patch v2.

Cheers,
Anders

> 
> >
> > -EXTRA_OEMAKE = "'ARCH=${TARGET_ARCH}' 'OPT=${CFLAGS}' 'CC=${CC}' BUILDTYPE=NATIVEONLY ${LIBARGS}"
> > +EXTRA_OEMAKE = "'ARCH=${ARCH}' 'OPT=${CFLAGS}' 'CC=${CC}' BUILDTYPE=NATIVEONLY ${LIBARGS}"
> >  CFLAGS += "-fexpensive-optimizations -frename-registers -fomit-frame-pointer -g0"
> >
> >  TARGET_CC_ARCH += "${LDFLAGS}"
> > --
> > 1.8.1.2
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel