[oe] [meta-networking][PATCH] openflow: import and tweak
Bruce Ashfield
bruce.ashfield at gmail.com
Tue Oct 8 18:13:24 UTC 2013
On Tue, Oct 8, 2013 at 1:18 PM, Joe MacDonald <joe at deserted.net> wrote:
> Hey Laszlo,
>
> [Re: [meta-networking][PATCH] openflow: import and tweak] On 13.10.08 (Tue 15:31) Laszlo Papp wrote:
>
>> Just to give an example about one of those critical issues: the recipe for 1.0
>> is even broken, as that should *not* use ./boot.sh.
>
> Okay. It didn't cause obvious problems for me and it seemed to be
> working for the guys using meta-virtualization, but I'm completely
> willing to believe it's not the right thing to do here. If you have an
> alternative suggestion or could help me understand the impact, please
> let me know.
>
>> On Tue, Oct 8, 2013 at 3:17 PM, Laszlo Papp <lpapp at kde.org> wrote:
>>
>> In short: please do not get this in if I may ask.
>>
>> The recipe from meta-virtual is flawed in my opinion and should be dropped,
>> and then rewritten,
>
> I recall you saying that, though I haven't encountered large problems
> with it yet. I'd appreciate any guidance you have to offer, of course,
> including a full rewrite.
>
>> especially since "Bruce" was so concerned about
>> license, reference and copyrights stuff. I would not mix his code into a
>> new layer for those issues.
>
> I'm not terribly concerned about attribution and copyright since he
> seems to have agreed with my approach here.
Yep.
Also, since non of the code is mine, I was just looking for a paper
trail back to
the old recipe and contributor for folks that were updating layers and
can follow
the recipe movement. I think my previous concerns were misunderstood.
So Joe's approach is fine, and I have no issues.
Full re-write, some combination .. they are all good. I'll just test meta-virt
against it no matter what, and send patches if things break.
>
>> By the way, I also mentioned that I would rewrite that. Is there any reason
>> why I did not get enough time for that contribution? I mean I have not even
>> been contacted about my status. Why did you not try to avoid the
>> cross-work?
>
> The last time this came around the thread was already pretty long before
> I even started with it and the last I'd seen suggested to me that you
> weren't interested in having this integrated anymore. I still thought
> there was value in it, so I started from your base and tried to address
> the open issues from the thread. Time-wise, a month has passed for
> something it sounded like would be done in a few days. I took that at
> confirmation that you were no longer pursuing this.
>
> Absolutely no slight was intended.
'nor here with my Ack of Joe's work. I was just waiting in the background as
well.
Cheers,
Bruce
>
> -J.
>
>>
>>
>> On Tue, Oct 8, 2013 at 2:37 PM, Bruce Ashfield <
>> bruce.ashfield at windriver.com> wrote:
>>
>> On 13-10-08 09:35 AM, Joe MacDonald wrote:
>>
>> Based on work by David Nyström (meta-virtualization) and Laszlo
>> Papp
>> (meta-oe).
>>
>> - Import OpenFlow 1.0 from meta-virtualization and provide an
>> updated
>> version of the recipe for the head of tree in the OpenFlow
>> git
>> repository.
>>
>> - Minor tweak in both recipes for do_install_append() spacing.
>>
>> - Update 'libssl' PACKAGECONFIG flag in both to follow the
>> 'openssl'
>> convention used elsewhere in meta-oe.
>>
>> - Create common include file for both versioned and git
>> recipes.
>>
>>
>> Awesome. I was just wondering about this a few days ago. I'll push a
>> removal of the meta-virt recipe, once this has merged to
>> meta-networking.
>>
>> Acked-by: Bruce Ashfield <bruce.ashfield at windriver.com>
>>
>>
>>
>>
>> Signed-off-by: Joe MacDonald <joe at deserted.net>
>> ---
>> .../recipes-protocols/openflow/openflow.inc | 35
>> ++++++++++++++++++++
>> .../recipes-protocols/openflow/openflow_1.0.bb | 4 +++
>> .../recipes-protocols/openflow/openflow_git.bb | 4 +++
>> 3 files changed, 43 insertions(+)
>> create mode 100644 meta-networking/recipes-protocols/openflow/
>> openflow.inc
>> create mode 100644 meta-networking/recipes-protocols/openflow/
>> openflow_1.0.bb
>> create mode 100644 meta-networking/recipes-protocols/openflow/
>> openflow_git.bb
>>
>> diff --git a/meta-networking/recipes-protocols/openflow/
>> openflow.inc b/meta-networking/recipes-protocols/openflow/
>> openflow.inc
>> new file mode 100644
>> index 0000000..43af54e
>> --- /dev/null
>> +++ b/meta-networking/recipes-protocols/openflow/openflow.inc
>> @@ -0,0 +1,35 @@
>> +SUMMARY = "OpenFlow communications protocol"
>> +DESCRIPTION = "\
>> +Open standard that enables researchers to run experimental
>> protocols in \
>> +contained networks. OpenFlow is a communications interface
>> between \
>> +control and forwarding planes of a software-defined networking
>> architecture.\
>> +"
>> +HOMEPAGE = "http://www.openflow.org"
>> +
>> +SECTION = "networking"
>> +LICENSE = "GPLv2"
>> +
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=
>> e870c934e2c3d6ccf085fd7cf0a1e2e2"
>> +
>> +SRC_URI = "git://gitosis.stanford.edu/openflow.git;protocol=git"
>> +
>> +DEPENDS = "virtual/libc"
>> +
>> +EXTRA_OECONF += "KARCH=${TARGET_ARCH}"
>> +
>> +PACKAGECONFIG ??= "openssl"
>> +PACKAGECONFIG[openssl] = "--enable-ssl,--disable-ssl, openssl,
>> libssl"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +inherit autotools
>> +
>> +do_configure() {
>> + ./boot.sh
>> + oe_runconf
>> +}
>> +
>> +do_install_append() {
>> + # Remove /var/run as it is created on startup
>> + rm -rf ${D}${localstatedir}/run
>> +}
>> diff --git a/meta-networking/recipes-protocols/openflow/
>> openflow_1.0.bb b/meta-networking/recipes-protocols/openflow/
>> openflow_1.0.bb
>> new file mode 100644
>> index 0000000..a7e254d
>> --- /dev/null
>> +++ b/meta-networking/recipes-protocols/openflow/openflow_1.0.bb
>> @@ -0,0 +1,4 @@
>> +include ${BPN}.inc
>> +
>> +SRCREV = "5ccca75a69f99791659bcfbcf35353ab1921320a"
>> +PV = "1.0"
>> diff --git a/meta-networking/recipes-protocols/openflow/
>> openflow_git.bb b/meta-networking/recipes-protocols/openflow/
>> openflow_git.bb
>> new file mode 100644
>> index 0000000..6403bfb
>> --- /dev/null
>> +++ b/meta-networking/recipes-protocols/openflow/openflow_git.bb
>> @@ -0,0 +1,4 @@
>> +include ${BPN}.inc
>> +
>> +SRCREV = "c84f33f09d5dbcfc9b489f64cb30475bf36f653a"
>> +PV = "1.0+git${SRCPV}"
>>
>>
>>
>>
>>
>>
>>
>
> --
> -Joe MacDonald.
> :wq
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
More information about the Openembedded-devel
mailing list