[oe] [meta-oe][PATCH v2] tcpreplay:add recipe

[Joe MacDonald]

[Re: [oe] [meta-oe][PATCH v2] tcpreplay:add recipe] On 13.10.31 (Thu 10:23) Martin Jansa wrote:

> On Thu, Oct 31, 2013 at 05:09:07PM +0800, Zongchun YU wrote:
> > Hi Martin.
> > 
> > Thanks for your kind comments. I see tcpdump in meta-oe layer too. tcpreplay
> > may use packages captured by tcpdump.
> > putting them in the same layer maybe better. Wish your suggestion?
> > 
> > Best Regards
> > Zongchun
> 
> +Joe
> 
> tcpdump is used only in one meta-oe recipe, were it can be dropped or
> replaced with PACKAGECONFIG
> 
> meta-oe/recipes-core/packagegroups/packagegroup-cli-tools.bb:    tcpdump
> 
> And then we can move tcpdump to meta-networking and add tcpreplay there.

Wow, been a while since I thought about tcpdump's location in the tree.
I knew we'd discussed moving it to meta-networking it previously and it
didn't move but I couldn't remember why.  Looks like it was mostly due
to inertia.  I've no objection to relocating it, I think it's a sensible
location for it anyway.  Zongchun:  would you be able to prepare a patch
set that includes the move and the introduction of tcpreplay?

As for the recipe itself, I only noticed two small things on a quick
scan.  tcpreplay-3.4.4-no-bfp-support.patch is lacking OE headers, at
least an upstream-status is important here, even though it's pretty
clear what that'll be.  :-)  Also, I don't think you need the PR in the
recipe.

-- 
-Joe MacDonald.
:wq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20131031/a0df7052/attachment-0002.sig>