[oe] [meta-java][PATCH 3/3] jamvm/java: allow spaces in arguments

Riku Voipio riku.voipio at linaro.org
Mon Sep 30 19:22:32 UTC 2013


On 30 September 2013 16:58, Eric Bénard <eric at eukrea.com> wrote:
> Hi Riku,
>
> Le Mon, 30 Sep 2013 16:46:11 +0300,
> Riku Voipio <riku.voipio at linaro.org> a écrit :
>
>> Current IFS mangling blows up on the face:
>>
>>     | configure:2341: javac  -classpath .: Test.java
>>     | Invalid maximum heap size: -Xmx1024m-cp/srv/oe/b
>>
>> Simpler command line expansion works just as easy.
>> ---
>>  recipes-core/jamvm/files/java | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/recipes-core/jamvm/files/java b/recipes-core/jamvm/files/java
>> index 27cf094..9a396a7 100755
>> --- a/recipes-core/jamvm/files/java
>> +++ b/recipes-core/jamvm/files/java
>> @@ -1,6 +1,5 @@
>>  #!/bin/sh
>>
>> -IFS=""
>> -export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:STAGING_LIBDIR_NATIVE/classpath:STAGING_LIBDIR_NATIVE/jamvm"
>> -export BOOTCLASSPATH="STAGING_DATADIR_NATIVE/jamvm/classes.zip:STAGING_DATADIR_NATIVE/classpath/glibj.zip"
>> -exec jamvm ${1+"$@"}
>> +export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/lib/classpath:/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/lib/jamvm"
>> +export BOOTCLASSPATH="/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/share/jamvm/classes.zip:/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/share/classpath/glibj.zip"
>> +exec jamvm "$@"

> so now we have your path "/srv/oe/build/tmp-eglibc/" hardcoded in the
> recipe ;-)

That is indeed not intended.. I was a bit uncertain with this patch,
as it was not clear to me why the IFS setting was needed.

Riku



More information about the Openembedded-devel mailing list