[oe] [PATCH V5] rrdtool: enable perl and python bindings

[Martin Jansa]

On Fri, Apr 25, 2014 at 04:22:07PM +0800, Chong Lu wrote:
> 
> On 04/25/2014 03:44 PM, Koen Kooi wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Chong Lu schreef op 25-04-14 04:22:
> >> 1. default enable perl and python bindings 2. rrdtool uses perl.real,
> >> perl.real doesn't know where the PERL5LIB should be when prebuilts are
> >> used. Use the wrapper perl instead, perl sets PERL5LIB and invokes
> >> perl.real 3. While using dash as /bin/sh, subsequent commands in
> >> functions will not use the environment variables passed to the function
> >> call line unless explicitly run "export ENV_VAR". 4. delete unrecognized
> >> options: "--enable-local-libpng" and "--enable-local-zlib"
> >>
> >> Signed-off-by: Chong Lu <Chong.Lu at windriver.com> ---
> >> meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb |  129
> >> ++++++++++++++++++++- 1 file changed, 123 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb
> >> b/meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb index
> >> 533451f..36785cd 100644 ---
> >> a/meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb +++
> >> b/meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb @@ -15,25 +15,142 @@
> >> SRC_URI = "http://oss.oetiker.ch/rrdtool/pub/rrdtool-${PV}.tar.gz \
> >> SRC_URI[md5sum] = "ffe369d8921b4dfdeaaf43812100c38f" SRC_URI[sha256sum] =
> >> "956aaf431c955ba88dd7d98920ade3a8c4bad04adb1f9431377950a813a7af11"
> >>
> >> -inherit autotools gettext +inherit autotools gettext pythonnative
> >> perlnative python-dir
> >>
> >> EXTRA_AUTORECONF = "-I m4"
> >>
> >> -PACKAGECONFIG ??= "" +PACKAGECONFIG ??= "python perl" +
> >> +PACKAGES_DYNAMIC += "^${PN}-perl ^${PN}-python"
> > No, just no. Martin said 'Add it to PACKAGES'.
> >
> If I add it to PACKAGES, I will get following errors:
> ERROR: QA Issue: rrdtool-perl is listed in PACKAGES multiple times, this 
> leads to packaging errors.
> ERROR: QA Issue: rrdtool-python is listed in PACKAGES multiple times, 
> this leads to packaging errors.

You need to remove mangling PACKAGES from populate_packages_prepend

> >> +python populate_packages_prepend() { +    def fill_more(name,
> >> rdep=None): +        if name is None or name.strip() == "": +
> >> return + +        fpack=d.getVar('PACKAGES') or "" +
> >> fpack="${PN}-" + name + " " + fpack +        d.setVar('PACKAGES', fpack)
> >> +        if rdep is not None: +
> >> prdep=d.getVar('RDEPENDS_${PN}-' + name) or "" +            prdep=rdep +
> >> " " + prdep +            d.setVar('RDEPENDS_${PN}-' + name, prdep) + +
> >> prdep=d.getVar('RDEPENDS_${PN}-' + name) or "" +            bb.debug(1,
> >> "RDEPENDS_${PN}-" + name + "=" + prdep) + +
> >> conf=(d.getVar('PACKAGECONFIG', True) or "").split() +
> >> pack=d.getVar('PACKAGES') or "" +    bb.debug(1, "PACKAGECONFIG=%s" %
> >> conf) +    bb.debug(1, "PACKAGES1=%s" % pack ) + +    if "perl" in conf
> >> : +        fill_more("perl") + +    if "python" in conf: +
> >> fill_more("python") + +    pack=d.getVar('PACKAGES', True) or "" +
> >> bb.debug(1, "PACKAGES after=%s" % pack) + +    #debug code +
> >> #prdep=d.getVar('RDEPENDS_${PN}') or "" +    #bb.debug(1,
> >> "RDEPENDS_${PN}" + "=" + prdep) +    #prdep=d.getVar('RDEPENDS') or "" +
> >> #bb.debug(1, "RDEPENDS" + "=" + prdep) +}
> > What is this?
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.5 (Darwin)
> > Comment: GPGTools - http://gpgtools.org
> >
> > iD8DBQFTWhJvMkyGM64RGpERArXTAJ4u1918rurp4h7aTEX6wW2/J0C+IgCeLLQc
> > ALaeAdoJhjuntnDEx23edT0=
> > =0QxD
> > -----END PGP SIGNATURE-----
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20140425/47a63826/attachment-0002.sig>