[oe] [meta-qt5][PATCH 1/4] qmake5_base.bbclass: Use Qt version path for headers

Otavio Salvador otavio at ossystems.com.br
Sun Feb 23 13:45:17 UTC 2014


On Sat, Feb 22, 2014 at 3:37 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
> On Fri, Feb 21, 2014 at 04:12:07PM -0500, Denys Dmytriyenko wrote:
>> On Fri, Feb 21, 2014 at 05:41:01PM -0300, Otavio Salvador wrote:
>> > When looking for Qt5 headers we ought to use the Qt5 specific path. In
>> > case the distribution wants to have a flat tree it can set QT_DIR_NAME
>> > and it will still works as expected.
>> >
>> > Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>>
>> Acked-by: Denys Dmytriyenko <denys at ti.com>
>>
>> Martin,
>>
>> Thinking about what you said in that Wiki section - I believe the number of
>> apps consuming headers from /usr/include/qt5 is much higher than number of
>> non-Qt5 libs/modules potentially installing headers in there... So, we
>> shouldn't require every app recipe to set PATH_HEADERS properly.
>
> Setting OE_QMAKE_PATH_HEADERS is simple oneline change:
> OE_QMAKE_PATH_HEADERS = "${OE_QMAKE_PATH_QT_HEADERS}"
>
> undoing this implementation isn't, if you really want to change
> OE_QMAKE_PATH_HEADERS then include QT_DIR_NAME in it, but leave
> OE_QMAKE_PATH_QT_HEADERS alone.

Ok; I will rework the patches and send a v2.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-devel mailing list