[oe] [meta-oe][PATCH v2] fbida 2.09: cleanups and use PACKAGECONFIG

[Paul Eggleton]

On Friday 28 February 2014 16:57:54 Martin Jansa wrote:
> On Fri, Feb 28, 2014 at 03:43:56PM +0000, Paul Eggleton wrote:
> > On Friday 28 February 2014 15:45:32 Martin Jansa wrote:
> > > On Fri, Feb 28, 2014 at 02:21:58PM +0000, Matthieu CRAPET wrote:
> > > > Thanks Martin for your great help!
> > > > 
> > > > Concerning shell function & tabs, maybe a line may be added in wiki:
> > > > http://www.openembedded.org/wiki/Migrating_metadata_to_OE-Core
> > > 
> > > Updated there and in
> > > http://www.openembedded.org/wiki/Styleguide
> > 
> > IMO, I think four spaces for multi-line indentation is not ideal. The
> > indentation is there for readability; it should line up with the opening
> > quote on the first line if there is one. IIRC we only ended up with these
> > after your search and replace in meta-oe because it was too hard to do
> > otherwise.
>
> http://lists.openembedded.org/pipermail/openembedded-core/2013-August/082663
> .html
> http://lists.openembedded.org/pipermail/openembedded-core/2013-August/08266
> 5.html
> http://lists.openembedded.org/pipermail/openembedded-core/2013-August/08286
> 8.html

My comment still stands.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre