[oe] [OE-core] [PATCH] core-image.bbclass: Reformat definition of CORE_IMAGE_BASE_INSTALL

[Khem Raj]

On Jul 12, 2014 1:41 AM, "Robert P. J. Day" <rpjday at crashcourse.ca> wrote:
>
> On Fri, 11 Jul 2014, Khem Raj wrote:
>
> > On Fri, Jul 11, 2014 at 4:41 PM, Otavio Salvador
> > <otavio at ossystems.com.br> wrote:
> > > Hello,
> > >
> > > +OE-Core
> > >
> > > On Fri, Jul 11, 2014 at 7:23 PM, Robert P. J. Day <
rpjday at crashcourse.ca> wrote:
> > >>
> > >> Reformat the assignment to CORE_IMAGE_BASE_INSTALL to be more
> > >> intuitively obvious.
> > >>
> > >> Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
> > >>
> > >> ---
> > >>
> > >>   compile and run-time tested, building a core-image-minimal for
> > >> qemuarm.
> > >>
> > >> diff --git a/meta/classes/core-image.bbclass
b/meta/classes/core-image.bbclass
> > >> index 1b36cba..d2b9d69 100644
> > >> --- a/meta/classes/core-image.bbclass
> > >> +++ b/meta/classes/core-image.bbclass
> > >> @@ -59,13 +59,11 @@ MACHINE_HWCODECS ??= ""
> > >>  CORE_IMAGE_BASE_INSTALL = '\
> > >>      packagegroup-core-boot \
> > >>      packagegroup-base-extended \
> > >> -    \
> > >> -    ${CORE_IMAGE_EXTRA_INSTALL} \
> > >>      '
> > >>
> > >>  CORE_IMAGE_EXTRA_INSTALL ?= ""
> > >>
> > >> -IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}"
> > >> +IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}
${CORE_IMAGE_EXTRA_INSTALL}"
> > >
> > > For me, more intuitively would be:
> > >
> > > CORE_IMAGE_BASE_INSTALL ?= ...
> >
> > weak assignment here would mean overridable base install which is
> > not the intention. we want a working base image when inheriting
> > core-image
>
>   except that that argument doesn't really hold water given how one
> can inherit core-image, then (as i pointed out) immediately wipe out
> that supposedly inviolable definition of CORE_IMAGE_BASE_INSTALL by
> simply reassigning to IMAGE_INSTALL.

these classes are provided as basic working blocks. it would be a bad use
case if one were to override basic constructs inside it completely. some
variables are sort of interfaces some are not. besides your change is ok
its just the preset is not. we should start using the constructs as
intended.
>
>   i *like* the idea of a weak assignment to CORE_IMAGE_BASE INSTALL.
> it's effectively what core-image-minimal is doing anyway, it just
> allows you to do it in a way that's not grotesquely ugly.
>
> rday
>
> --
>
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                         http://crashcourse.ca
>
> Twitter:                                       http://twitter.com/rpjday
> LinkedIn:                               http://ca.linkedin.com/in/rpjday
> ========================================================================