[oe] [meta-oe][PATCH 3/7] can-utils: Create git version

[Otavio Salvador]

Hello Lauren and Martin,

On Tue, Mar 11, 2014 at 11:08 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
> On Fri, Mar 07, 2014 at 03:26:11PM -0600, Lauren Post wrote:
>> Linux CAN network development utilities - newer version than canutils
>>
>> Signed-off-by: Lauren Post <lauren.post at freescale.com>
>> ---
>>  .../recipes-extended/socketcan/can-utils_git.bb    |   14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>  create mode 100644 meta-oe/recipes-extended/socketcan/can-utils_git.bb
>>
>> diff --git a/meta-oe/recipes-extended/socketcan/can-utils_git.bb b/meta-oe/recipes-extended/socketcan/can-utils_git.bb
>> new file mode 100644
>> index 0000000..53632c8
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/socketcan/can-utils_git.bb
>> @@ -0,0 +1,14 @@
>> +SUMMARY = "Linux CAN network development utilities"
>> +DESCRIPTION = "Linux CAN network development"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
>
> Please use something from source tree, not COREBASE.

I did a check in the contents and it seems to be a mix of licenses:

$: licensecheck -r *
asc2log.c: BSD (3 clause)
autogen.sh: *No copyright* UNKNOWN
bcmserver.c: *No copyright* UNKNOWN
canbusload.c: BSD (3 clause)
can-calc-bit-timing.c: GPL
candump.c: BSD (3 clause)
canfdtest.c: GPL
canframelen.c: BSD (3 clause)
canframelen.h: BSD (3 clause)
cangen.c: BSD (3 clause)
cangw.c: BSD (3 clause)
canlogserver.c: BSD (3 clause)
canplayer.c: BSD (3 clause)
cansend.c: BSD (3 clause)
cansniffer.c: BSD (3 clause)
include/linux/can.h: BSD (3 clause)
include/linux/can/bcm.h: BSD (3 clause)
include/linux/can/error.h: BSD (3 clause)
include/linux/can/gw.h: BSD (3 clause)
include/linux/can/isotp.h: BSD (3 clause)
include/linux/can/netlink.h: UNKNOWN
include/linux/can/raw.h: BSD (3 clause)
isotpdump.c: BSD (3 clause)
isotprecv.c: BSD (3 clause)
isotpsend.c: BSD (3 clause)
isotpserver.c: BSD (3 clause)
isotpsniffer.c: BSD (3 clause)
isotptun.c: BSD (3 clause)
lib.c: BSD (3 clause)
lib.h: BSD (3 clause)
log2asc.c: BSD (3 clause)
log2long.c: BSD (3 clause)
slcan_attach.c: BSD (3 clause)
slcand.c: GPL (v2 or later) (with incorrect FSF address)
slcanpty.c: GPL (v2 or later) (with incorrect FSF address)
terminal.h: BSD (3 clause)

>> +DEPENDS = "libsocketcan"
>> +
>> +SRC_URI = "git://git.gitorious.org/linux-can/can-utils.git;protocol=git;branch=master"

I'd use:

SRC_URI = "git://gitorious.org/linux-can/can-utils.git;protocol=git;branch=master"

As this is the common form used in the current recipes.

>> +SRCREV = "67a2bdcd336e6becfa5784742e18c88dbeddc973"
>
> Please set PV.

As it has not been tagged in the repository I'd use:

PV = "0.0+git${SRCPV}"

here.

>> +S = "${WORKDIR}/git"
>> +
>> +inherit autotools pkgconfig
...

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750