[oe] [PATCH] pm-qa-utils: Add power management test utils

[Maupin, Chase]

Sincerely,
Chase Maupin
Integration Team Manager
Linux Core Product Development
e-mail: chase.maupin at ti.com
phone: (214) 567-2950

For support:
Forums - http://community.ti.com/forums/
Wiki - http://wiki.davincidsp.com/ 


>-----Original Message-----
>From: openembedded-devel-bounces at lists.openembedded.org
>[mailto:openembedded-devel-bounces at lists.openembedded.org] On
>Behalf Of Koen Kooi
>Sent: Friday, March 21, 2014 4:10 AM
>To: openembedded-devel at lists.openembedded.org
>Subject: Re: [oe] [PATCH] pm-qa-utils: Add power management test
>utils
>
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>Chase Maupin schreef op 20-03-14 15:47:
>> * The power management test utilities from Linaro can be used to
>test
>> multiple PM features such as cpufreq, cpuidle, thermal control
>and
>> suspend operations. * These utilities are not platform specific
>and can
>> be used by a broader base of users.
>>
>> Signed-off-by: Chase Maupin <Chase.Maupin at ti.com>
>
>Everything refers to this as 'pm-qa', not 'pm-qa-utils'

I assume you are saying you would rather see this recipe as pm-qa instead of pm-qa-utils?

>
>> --- .../pm-qa-utils/pm-qa-utils_git.bb                 |   63
>> ++++++++++++++++++++ 1 file changed, 63 insertions(+) create
>mode 100644
>> meta-oe/recipes-devtools/pm-qa-utils/pm-qa-utils_git.bb
>>
>> diff --git a/meta-oe/recipes-devtools/pm-qa-utils/pm-qa-
>utils_git.bb
>> b/meta-oe/recipes-devtools/pm-qa-utils/pm-qa-utils_git.bb new
>file mode
>> 100644 index 0000000..610f3a7 --- /dev/null +++
>> b/meta-oe/recipes-devtools/pm-qa-utils/pm-qa-utils_git.bb @@ -
>0,0 +1,63
>> @@ +DESCRIPTION = "Utilities from Linaro for testing Power
>Management"
>> +HOMEPAGE =
>>
>"https://wiki.linaro.org/WorkingGroups/PowerManagement/Resources/T
>estSuite/PmQa"
>>
>>
>+
>> +LICENSE = "GPLv2" +LIC_FILES_CHKSUM =
>> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" + +PV =
>"0.4.4" +
>> +BRANCH ?= "master" +SRCREV =
>"fbc2762359b863dfbf4fd0bab1e8abd2a6125ed4"
>> + +SRC_URI =
>> "git://git.linaro.org/tools/pm-
>qa.git;protocol=git;branch=${BRANCH}" + +S
>> = "${WORKDIR}/git" + +CFLAGS += "-pthread" + +do_compile () { +
># Find
>> all the .c files in this project and build them. +    for x in
>`find .
>> -name "*.c"` +    do +        util=`echo ${x} | sed s/.c$//` +
>> oe_runmake ${util} +    done +} + +do_install () { +    install
>-d
>> ${D}${bindir} +    install -d ${D}${bindir}/linaro-pm-qa-include
>
>Please don't use subdirs in $bindir, that's what $libdir and
>$libexecdir are
>for.

Good point.  I did this because the script going into that directory was named "functions.sh" in the original sources.  I thought this was a bit generic and could possibly conflict.

What are your thoughts on a subdirectory under $libdir or $libexecdir?  Any preference?

>
>> + +    # Install the compiled binaries the were built in the
>previous
>> step +    for x in `find . -name "*.c"` +    do +
>util=`echo ${x}
>> | sed s/.c$//` +        util_basename=`basename ${util}` +
>install
>> -m 0755 ${util} ${D}${bindir}/${util_basename} +    done + +
># Install
>> the helper scripts in the include directory +    for script in
>`find .
>> -name "*.sh" | grep include` +    do +        # Remove hardcoded
>relative
>> paths +        sed -i -e 's#..\/utils\/##' ${script} + +
>> script_basename=`basename ${script}` +        install -m 0755
>$script
>> ${D}${bindir}/linaro-pm-qa-include/${script_basename} +    done
>+ +    #
>> Install the shell scripts NOT in the include directory since
>those +    #
>> will be installed elsewhere +    for script in `find . -name
>"*.sh" |
>> grep -v include` +    do +        # if the script includes any
>helper
>> scripts from the include +        # directory then change the
>include
>> path to the absolute path +        # to reflect the install
>location of
>> the helper scripts. +        sed -i -e "s#source
>../include#source
>> ${bindir}/linaro-pm-qa-include#g" ${script} +        # Remove
>hardcoded
>> relative paths +        sed -i -e 's#..\/utils\/##' ${script} +
>+
>> script_basename=`basename ${script}` +        install -m 0755
>$script
>> ${D}${bindir}/${script_basename} +    done +}
>>
>
>-----BEGIN PGP SIGNATURE-----
>Version: GnuPG v1.4.5 (Darwin)
>Comment: GPGTools - http://gpgtools.org
>
>iD8DBQFTLAHbMkyGM64RGpERAp4tAKCqvpUtLAnW+JmNPFue3devsMkfEgCfSBG8
>sTfb/tlOntd8/Hs/1JvXqQ4=
>=674M
>-----END PGP SIGNATURE-----
>
>--
>_______________________________________________
>Openembedded-devel mailing list
>Openembedded-devel at lists.openembedded.org
>http://lists.openembedded.org/mailman/listinfo/openembedded-devel