[oe] [meta-networking][PATCH v3 2/2] netperf: enable SCTP support

[Paul Eggleton]

Hi Mihaela,

On Friday 02 May 2014 15:36:41 Mihaela Sendrea wrote:
> Signed-off-by: Mihaela Sendrea <mihaela.sendrea at enea.com>
> ---
>  meta-networking/recipes-support/netperf/netperf_2.6.0.bb |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb index
> 45760ad..64e3be0 100644
> --- a/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> +++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> @@ -27,6 +27,9 @@ CFLAGS_append = " -DDO_UNIX -DDO_IPV6 -D_GNU_SOURCE"
>  CFLAGS_append = "${@base_contains('DISTRO_FEATURES', 'largefile', \
>      ' -D_FILE_OFFSET_BITS=64', '', d)}"
> 
> +PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'sctp', 'sctp', '',
> d)}" 

Do you anticipate a number of other recipes enabling and disabling SCTP 
support? Typically we only add DISTRO_FEATURES where that's the case, rather 
than just for individual recipes (that's why PACKAGECONFIG was created.)

> +PACKAGECONFIG[sctp] =
> "--enable-sctp,--disable-sctp,lksctp-tools,kernel-module-sctp" 

Sorry to be a pain, I should have noticed this earlier - but the result of 
this will be that the recipe breaks if sctp is enabled but sctp functionality 
is compiled into the kernel rather than being a module. Since PACKAGECONFIG 
doesn't directly support adding RRECOMMENDS I'm afraid you'll need to set it 
separately based on whether sctp is in PACKAGECONFIG.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre