[oe] [meta-networking][PATCH] ifplugd: Added ifplugd recipe.

[Paul Eggleton]

On Wednesday 07 May 2014 11:34:23 Paul Eggleton wrote:
> Hi Søren,
> 
> So leaving aside that ifplugd is completely dead upstream, a few small
> pieces of feedback on the recipe:
> 
> On Wednesday 07 May 2014 11:26:17 Søren Holm wrote:
> > Signed-off-by: Søren Holm <sgh at sgh.dk>
> > ---
> > 
> >  .../ifplugd/files/ifplugd.conf                     | 42
> > 
> > ++++++++++++++++++++++ .../recipes-connectivity/ifplugd/ifplugd_0.28.bb  
> > |
> > 23 ++++++++++++ 2 files changed, 65 insertions(+)
> > 
> >  create mode 100644
> > 
> > meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf create
> > mode
> > 100644 meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb
> > 
> > diff --git
> > a/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf
> > b/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new
> > file mode 100644
> > index 0000000..1e0f83a
> > --- /dev/null
> > +++ b/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf
> > @@ -0,0 +1,42 @@
> > +# -*-sh-*-
> > +# $Id: ifplugd.conf 43 2003-09-13 11:25:11Z lennart $
> > +
> > +# This file is part of ifplugd.
> > +#
> > +# ifplugd is free software; you can redistribute it and/or modify it
> > under
> > +# the terms of the GNU General Public License as published by the Free
> > +# Software Foundation; either version 2 of the License, or (at your
> > +# option) any later version.
> > +#
> > +# ifplugd is distributed in the hope that it will be useful, but WITHOUT
> > +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> > +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
> > +# for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with ifplugd; if not, write to the Free Software Foundation,
> > +# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
> > +
> > +# ifplugd configuration file
> > +
> > +# Please note that this is a bourne shell fragment sourced by the
> > +# init script of ifplugd.
> > +
> > +# Specify the interfaces to control here, separated by spaces.
> > +# Ifplugd processes will be started for each of these interfaces when
> > +# the ifplugd init script is called with the "start" argument. You may
> > +# use the magic string "auto" to make the init script start or stop
> > +# ifplugd processes for ALL eth and wlan interfaces that are available
> > +# according to /proc/net/dev. Note that the list of interfaces
> > +# appearing in /proc/net/dev may depend on which kernel modules you
> > +# have loaded.
> > +INTERFACES="eth0"
> > +
> > +# Additional parameters for ifplugd.
> > +# (Run "ifplugd -h" for further information.)
> > +ARGS="-fwI -u0 -d10"
> > +
> > +# Additional parameters for ifplugd for the specified interface.  Note
> > +# that $ARGS is ignored, when a variable like this is set for an
> > +# interface
> > +#ARGS_wlan0="-MwI -u5 -d5"
> > diff --git a/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb
> > b/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file
> > mode 100644
> > index 0000000..340d5f4
> > --- /dev/null
> > +++ b/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb
> > @@ -0,0 +1,23 @@
> > +DESCRIPTION = "Daemon for monitoring ethernet device link state"
> 
> Please use SUMMARY instead of DESCRIPTION of a

Sorry, that should have been "Please use SUMMARY instead of DESCRIPTION for a 
short description like this".

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre