[oe] [meta-networking][PATCH] strongswan: Security Advisory - strongswan - CVE-2014-2338

[Joe MacDonald]

Merged, thanks Roy.

-J.

[[oe] [meta-networking][PATCH] strongswan: Security Advisory - strongswan - CVE-2014-2338] On 14.05.09 (Fri 17:05) rongqing.li at windriver.com wrote:

> From: Yue Tao <Yue.Tao at windriver.com>
> 
> IKEv2 in strongSwan 4.0.7 before 5.1.3 allows remote attackers to bypass
> authentication by rekeying an IKE_SA during (1) initiation or (2)
> re-authentication, which triggers the IKE_SA state to be set to
> established.
> 
> http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-2338
> 
> Signed-off-by: Yue Tao <Yue.Tao at windriver.com>
> Signed-off-by: Roy Li <rongqing.li at windriver.com>
> ---
>  .../strongswan-5.0.0-5.1.2_reject_child_sa.patch   |   36 ++++++++++++++++++++
>  .../recipes-support/strongswan/strongswan_5.1.1.bb |    1 +
>  2 files changed, 37 insertions(+)
>  create mode 100644 meta-networking/recipes-support/strongswan/files/strongswan-5.0.0-5.1.2_reject_child_sa.patch
> 
> diff --git a/meta-networking/recipes-support/strongswan/files/strongswan-5.0.0-5.1.2_reject_child_sa.patch b/meta-networking/recipes-support/strongswan/files/strongswan-5.0.0-5.1.2_reject_child_sa.patch
> new file mode 100644
> index 0000000..ab95992
> --- /dev/null
> +++ b/meta-networking/recipes-support/strongswan/files/strongswan-5.0.0-5.1.2_reject_child_sa.patch
> @@ -0,0 +1,36 @@
> +From b980ba7757dcfedd756aa055b3271ea58cf85aa6 Mon Sep 17 00:00:00 2001
> +From: Martin Willi <martin at revosec.ch>
> +Date: Thu, 20 Feb 2014 16:08:43 +0100
> +Subject: [PATCH] ikev2: Reject CREATE_CHILD_SA exchange on unestablished
> + IKE_SAs
> +
> +Prevents a responder peer to trick us into established state by starting
> +IKE_SA rekeying before the IKE_SA has been authenticated during IKE_AUTH.
> +
> +Fixes CVE-2014-2338 for 5.x versions of strongSwan.
> +---
> + src/libcharon/sa/ikev2/task_manager_v2.c | 9 +++++++++
> + 1 file changed, 9 insertions(+)
> +
> +diff --git a/src/libcharon/sa/ikev2/task_manager_v2.c b/src/libcharon/sa/ikev2/task_manager_v2.c
> +index ac3be90..a5252ab 100644
> +--- a/src/libcharon/sa/ikev2/task_manager_v2.c
> ++++ b/src/libcharon/sa/ikev2/task_manager_v2.c
> +@@ -780,6 +780,15 @@ static status_t process_request(private_
> + 			case CREATE_CHILD_SA:
> + 			{	/* FIXME: we should prevent this on mediation connections */
> + 				bool notify_found = FALSE, ts_found = FALSE;
> ++
> ++				if (this->ike_sa->get_state(this->ike_sa) == IKE_CREATED ||
> ++					this->ike_sa->get_state(this->ike_sa) == IKE_CONNECTING)
> ++				{
> ++					DBG1(DBG_IKE, "received CREATE_CHILD_SA request for "
> ++						 "unestablished IKE_SA, rejected");
> ++					return FAILED;
> ++				}
> ++
> + 				enumerator = message->create_payload_enumerator(message);
> + 				while (enumerator->enumerate(enumerator, &payload))
> + 				{
> +--
> +1.8.1.2
> diff --git a/meta-networking/recipes-support/strongswan/strongswan_5.1.1.bb b/meta-networking/recipes-support/strongswan/strongswan_5.1.1.bb
> index a2a2333..f8116e3 100644
> --- a/meta-networking/recipes-support/strongswan/strongswan_5.1.1.bb
> +++ b/meta-networking/recipes-support/strongswan/strongswan_5.1.1.bb
> @@ -9,6 +9,7 @@ DEPENDS = "gmp openssl flex-native flex bison-native"
>  
>  SRC_URI = "http://download.strongswan.org/strongswan-${PV}.tar.bz2 \
>          file://fix-funtion-parameter.patch \
> +        file://strongswan-5.0.0-5.1.2_reject_child_sa.patch \
>  "
>  
>  SRC_URI[md5sum] = "e3af3d493d22286be3cd794533a8966a"
> -- 
> 1.7.10.4
> 
-- 
-Joe MacDonald.
:wq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20140509/f61faf88/attachment-0002.sig>