[oe] [PATCH 11/13] sdparm: add bash to RDEPENDS_sdparm

[Robert Yang]

On 09/05/2014 05:10 AM, Randy MacLeod wrote:
> On 14-09-01 11:18 AM, Robert Yang wrote:
>> Bash scripts:
>> packages-split/sdparm/usr/bin/sas_disk_blink:#!/bin/bash
>> packages-split/sdparm/usr/bin/scsi_ch_swp:#!/bin/bash
>>
>> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>> ---
>>   meta-oe/recipes-support/sdparm/sdparm_1.08.bb |    2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-oe/recipes-support/sdparm/sdparm_1.08.bb
>> b/meta-oe/recipes-support/sdparm/sdparm_1.08.bb
>> index 713e451..be46b96 100644
>> --- a/meta-oe/recipes-support/sdparm/sdparm_1.08.bb
>> +++ b/meta-oe/recipes-support/sdparm/sdparm_1.08.bb
>> @@ -15,3 +15,5 @@ SRC_URI[md5sum] = "be5786f37499018ef44f409597c92d42"
>>   SRC_URI[sha256sum] =
>> "376b78a414b1a9c47f3f13dbeb963e7a3ec7be126f83927d6856b5f7ac425e57"
>>
>>   inherit autotools
>> +
>> +RDEPENDS_${PN} += "bash"
>>
>
> We should move these scripts to a sdparm-scripts sub-pkg.

Good idea, I will do it.

// Robert

>
> sdparm is a ~150K executable so making it pull in bash
> at >1000K isn't good for embedded systems.
>
>
> Neither script appears to be essential:
>
> sas_disk_blink - blink the LED on a SAS disk
>
> scsi_ch_swp:
>       "Usage: scsi_ch_swp [-h] [-s 0|1] [-v] [-w] <blk_device>"
> ...
>       "Access the Software Write Protect (SWP) bit in the SCSI control"
>       "mode page and if changed adjust the Linux block device (e.g."
>       "/dev/sdc) settings accordingly. If supported, when the SWP bit"
>       "is set (1) the device is read-only; when clear (0) the device"
>       "is read-write (i.e. its contents can be read and changed)."
>       "When no options given it reads SWP and gets blockdev's RO flag."
>
>
> Comments or concerns?
>