[oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

Mike Looijmans mike.looijmans at topic.nl
Wed Sep 10 17:08:37 UTC 2014


Wouldn't it be a LOT more constructive to fix the bashism. I fail to see 
the virtue in adding 2MB of "bash" to an embedded system just for a text 
echo statement that no-one will actually read unless they hook up a 
serial console to their TV set or so.


On 9-9-2014 18:27, Robert Yang wrote:
> Bashism:
> [snip]
> possible bashism in autofs/etc/init.d/autofs line 116 ($"foo" should be eval_gettext "foo"):
>                  echo $"$prog not running"
> possible bashism in autofs/etc/init.d/autofs line 120 ($"foo" should be eval_gettext "foo"):
>                  echo $"Reloading maps"
> possible bashism in autofs/etc/init.d/autofs line 150 ($"foo" should be eval_gettext "foo"):
>                  echo $"Usage: $0 {start|forcestart|stop|restart|forcerestart|reload}"
> [snip]
>
> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> ---
>   .../recipes-daemons/autofs/autofs_5.1.0.bb         |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb b/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb
> index aab2187..06ee77b 100644
> --- a/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb
> +++ b/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb
> @@ -4,6 +4,7 @@ LICENSE = "GPL-2.0"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>
>   DEPENDS += "libtirpc flex-native bison-native"
> +RDEPENDS_${PN} += "bash"
>
>   inherit autotools-brokensep systemd
>
>


-- 
Mike Looijmans



More information about the Openembedded-devel mailing list