[oe] [meta-java] [Openjdk-8 enabling patch]

Awasthi, Vinay K vinay.k.awasthi at intel.com
Thu Aug 6 16:35:44 UTC 2015


Hi Maxin,
Thanks for the quick feedback... 
I will resend it today..(going over guidelines etc..)
~Vinay

-----Original Message-----
From: Maxin B. John [mailto:maxin.john at enea.com] 
Sent: Thursday, August 6, 2015 7:48 AM
To: Awasthi, Vinay K
Cc: openembedded-devel at lists.openembedded.org; 'mario at ossystems.com.br'; 'otavio at ossystems.com.br'
Subject: Re: [oe] [meta-java] [Openjdk-8 enabling patch]

Hi,

On Wed, Aug 05, 2015 at 07:29:00PM +0000, Awasthi, Vinay K wrote:
> diff --git 
> recipes-core/openjdk/openjdk-8-8u40b27/cacao-arm-ucontext.patch
> 
> +        return "LIBFFI_LIBS=-lffi"
> 
> +    else:
> 
> +        return ""
>

Agree with Otavio and Paul here. Please re-do the patch as described in the README with a reasonable commit message and we will be happy to review it :)

Best Regards,
Maxin



More information about the Openembedded-devel mailing list