[oe] [meta-multimedia][PATCH 2/4] mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5

[Khem Raj]

On Mon, Dec 7, 2015 at 11:58 AM, Andre McCurdy <armccurdy at gmail.com> wrote:
> On Mon, Dec 7, 2015 at 10:28 AM, Khem Raj <raj.khem at gmail.com> wrote:
>> On Thu, Dec 3, 2015 at 7:21 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>>> ---
>>>  meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>> index a3225f2..0625634 100644
>>> --- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>> +++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>> @@ -57,4 +57,5 @@ EXTRA_OECONF = " \
>>>  #| {standard input}:48: Error: shifts in CMP/MOV instructions are only supported in unified syntax -- `mov r5,r5,lsr#24'
>>>  #...
>>>  #| make[3]: *** [equalizer.lo] Error 1
>>> -ARM_INSTRUCTION_SET = "arm"
>>> +ARM_INSTRUCTION_SET_armv4 = "arm"
>>> +ARM_INSTRUCTION_SET_armv5 = "arm"
>>
>> how does is fix the problem ? I think it might just be hiding real problem
>
> You mean the problem that upstream packages don't seem to care much
> about Thumb1 any more?
>
> I wasn't attempting to fix that, just to allow Thumb2 for CPUs which support it.

ARM mode should have worked for chips using armv7+ as well so my
question was if there is a general problem of compiling mpg123 in arm
mode.
or something else. The change in itself is fine it limits the scope to
armv5 and older.