[oe] [meta-qt5][PATCH] cmake_qt5.bbclass: add DEPENDS to qtbase

Mikko.Rapeli at bmw.de Mikko.Rapeli at bmw.de
Wed Dec 9 09:24:12 UTC 2015


On Wed, Dec 09, 2015 at 10:19:09AM +0100, Martin Jansa wrote:
> On Wed, Dec 09, 2015 at 10:53:24AM +0200, Mikko Rapeli wrote:
> > All packages using this class need it and it is too easy for developers
> > to miss and leave race conditions into builds.
> > 
> > Change-Id: I713ffdf26e821b8ab12c2d53f9a1e6679d26a4b1
> 
> You don't need Change-Id.

Ok, removing.

> > Signed-off-by: Mikko Rapeli <mikko.rapeli at bmw.de>
> > ---
> >  classes/cmake_qt5.bbclass | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
> > index 94a60dc..10b0312 100644
> > --- a/classes/cmake_qt5.bbclass
> > +++ b/classes/cmake_qt5.bbclass
> > @@ -1,6 +1,8 @@
> >  inherit cmake
> >  inherit qmake5_paths
> >  
> > +DEPENDS_prepend = " qtbase "
> 
> You don't need leading space in prepend, only the trailing one.

I did at some point on dizzy but will remove.

-Mikko


More information about the Openembedded-devel mailing list