[oe] [meta-qt5][dizzy][PATCH] qmake5: don't always look in directories recursively

Otavio Salvador otavio at ossystems.com.br
Mon Feb 23 12:56:29 UTC 2015


On Mon, Feb 23, 2015 at 9:51 AM, Alexandre Belloni
<alexandre.belloni at free-electrons.com> wrote:
> Hi,
>
> (I was not in copy of your reply)
>
> On 19/02/2015 at 17:07:43 -0200, Otavio Salvador wrote :
>> > diff --git a/recipes-qt/qt5/qt5.inc b/recipes-qt/qt5/qt5.inc
>> > index bb0bcdcac0af..22f0d30e0298 100644
>> > --- a/recipes-qt/qt5/qt5.inc
>> > +++ b/recipes-qt/qt5/qt5.inc
>> > @@ -18,6 +18,8 @@ OE_QMAKE_PATH_SETTINGS = "${OE_QMAKE_PATH_QT_SETTINGS}"
>> >  OE_QMAKE_PATH_EXAMPLES = "${OE_QMAKE_PATH_QT_EXAMPLES}"
>> >  OE_QMAKE_PATH_TESTS = "${OE_QMAKE_PATH_QT_TESTS}"
>> >
>> > +OE_QMAKE_RECURSIVE = ""
>>
>> Shouldn't this to be done for qtbase only?
>
> No, this has to be done for all the qt packages. The packages exhibiting
> the problem are qtdeclarative and qt3d.
> That fix is coming from a discussion I had with people from the QT
> Company.
>
> Actually, I think -r shouldn't be the default but let's not break
> current users of the qmake5 class.

In this case, yes. But I would than prefer if you could change the
default in a following commit so people can refer it if there are
problems.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-devel mailing list