[oe] [meta-oe][PATCH] socorro-syms: Add Breakpad symbol generation adapted for Socorro

Anders Darander anders at chargestorm.se
Wed Feb 25 21:39:18 UTC 2015


Just a small nitpick or comment.

On 24 Feb 2015 14:25, "Daniel Markus" <daniel.markus at leica-geosystems.com>
wrote:
.
> +#
> +# Use example:
> +#
> +# inherit breakpad
> +# inherit socorro-syms
> +# BREAKPAD_BIN = "YourBinary"
> +#
> +
> +# We depend on Breakpad creating the original symbol file.
> +DEPENDS += "breakpad"

Is this necessary? If the recipe using this class files your instructions
and inherits breakpad, this is already added to DEPENDS. And of the recipe
doesn't inherit breakpad, it won't work anyway...

Maybe you should have your class inherit breakpad directly, and only
instruct the recipe author top add BREAKPAD_BIN to the recipes using this
class?

Cheers,
Anders



More information about the Openembedded-devel mailing list