[oe] [meta-oe][PATCH] fio: Add PACKAGECONFIG for numa, re-enable ARM build

[Andre McCurdy]

Hi Dominic,

On Thu, Jul 16, 2015 at 5:45 AM, Dominic Sacré <dominic.sacre at gmx.de> wrote:
> Make fio's NUMA support optional via PACKAGECONFIG.
> Enable this feature by default, except on ARM where libnuma/numactl
> is not available.
>
> Signed-off-by: Dominic Sacré <dominic.sacre at gmx.de>
> ---
>  meta-oe/recipes-benchmark/fio/fio_2.2.6.bb | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-benchmark/fio/fio_2.2.6.bb b/meta-oe/recipes-benchmark/fio/fio_2.2.6.bb
> index 82f9cd4..1255441 100644
> --- a/meta-oe/recipes-benchmark/fio/fio_2.2.6.bb
> +++ b/meta-oe/recipes-benchmark/fio/fio_2.2.6.bb
> @@ -10,10 +10,13 @@ SECTION = "console/tests"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
>
> -DEPENDS = "libaio zlib numactl"
> +DEPENDS = "libaio zlib"
> +
> +PACKAGECONFIG ??= "numa"
> +PACKAGECONFIG[numa] = ",--disable-numa,numactl"

I don't think this change will work.

The fio recipe doesn't use autotools, so the --disable-numa option set
via PACKAGECONFIG isn't going to have any effect unless you also
manually pass EXTRA_OECONF into the build somehow.

>  # ARM does not currently support NUMA
> -COMPATIBLE_HOST = "^((?!arm).*)$"
> +PACKAGECONFIG_remove_arm = "numa"

In general, it would be better to use something like:

  PACKAGECONFIG_NUMA = "numa"
  PACKAGECONFIG_NUMA_arm = ""

  PACKAGECONFIG ??= "${PACKAGECONFIG_NUMA}"

_remove can be a little difficult to 'over-ride', so makes things
harder if someone did, one day, want to experiment with enabling that
option from local.conf or a .bbappend.

>  # rev for v2.2.6
>  SRCREV = "f52c9691bc8c285f3445235c69acdfd6de7f9b82"
> --
> 2.4.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel