[oe] [meta-java][PATCH] initials: silence "populate_sysroot manifest not found" warnings

[Henning Heinold]

On Tue, Mar 10, 2015 at 12:07:55PM -0300, Otavio Salvador wrote:
> On Tue, Mar 10, 2015 at 11:54 AM,  <magnus at minimum.se> wrote:
> >> On Tue, Mar 10, 2015 at 9:19 AM, Magnus Olsson <magnus at minimum.se> wrote:
> >>> A number of recipes in meta-java use autotools.bbclass for building;
> >>> internally
> >>> it uses the sstate-control populate_sysroot manifests to locate and copy
> >>> aslocals for configure dependencies as part of the do_configure step.
> >>> The manifest path differs depending on if it's a native package or not
> >>> so
> >>> autotools.bbclass looks at the package name to determine if its native
> >>> or not
> >>> (it's native if it ends with "-native").
> >>>
> >>> The warnings are emitted because a few (native) recipes in meta-java
> >>> (such as
> >>> cacao-initial, classpath-initial and more) are incorrectly being
> >>> classified as
> >>> non-native by autotools.bbclass, which makes it look for the manifest in
> >>> the
> >>> wrong place and finally gives up with the warning:
> >>>
> >>> WARNING:
> >>> /home/oe/tmp-glibc/sstate-control/manifest-mymachine-libecj-bootstrap.populate_sysroot
> >>> not found
> >>>
> >>> This happens for cacao-initial, classpath-initial, ecj-initial,
> >>> libecj-boostrap,
> >>> jamvm-initial and jikes-initial since they are all native and rely on
> >>> autotools.
> >>>
> >>> This patch renames the recipes so they end with -native, e.g
> >>> ecj-initial-native.
> >>> It also updates the recipes so they DEPEND on the corresponding new
> >>> name. This
> >>> helps autotools.bbclass to properly classify the recipes are native and
> >>> silence
> >>> the warnings.
> >>>
> >>> Signed-off-by: Magnus Olsson <magnus at minimum.se>
> >>
> >> What about the target packages? instead a class extend could be used.
> >
> > autotools.bbclass will assume it's a target package if the name doesn't
> > end with -native or starts with -nativesdk (kind of a catch-all), so
> > target packages should be fine.
> >
> > I think autotools.bbclass::autotools_copy_aclocals() can be patched to use
> > bb.data.inherits_class() to detect native and nativesdk packages (and so
> > will not need to look at the package name), but I still feel like this is
> > a good patch for meta-java since a -native prefix seem to be more or less
> > package name convention.
> 
> You've renamed the recipes. Has the corresponding target ones been
> preserved? I will check more carefully the patch today or tomorrow ...

It only effects recipes we needs to build the jdk, no target packages are effected.

Bye Henning