[oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
Martin Jansa
martin.jansa at gmail.com
Mon May 11 09:09:52 UTC 2015
On Mon, May 04, 2015 at 08:18:20PM -0700, Armin Kuster wrote:
> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build dependency? [build-deps]
>
> Signed-off-by: Armin Kuster <akuster808 at gmail.com>
> ---
> .../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> index 8d37c98..36a4a7e 100644
> --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> @@ -37,11 +37,12 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
> PACKAGECONFIG[systemd] = " \
> --with-systemdsystemunitdir=${systemd_unitdir}/system --with-session-tracking=systemd --enable-polkit, \
> --without-systemdsystemunitdir, \
> - polkit \
> + polkit, polkit \
> "
> # consolekit is not picked by shlibs, so add it to RDEPENDS too
> PACKAGECONFIG[consolekit] = "--with-session-tracking=consolekit,,consolekit,consolekit"
> PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
Shouldn't it have polkit as build time dependency (3rd argument, not 4th)
Also the subject is wrong, it's networkmanager, not networkingmanager.
>
> # Work around dbus permission problems since we lack a proper at_console
> do_install_prepend() {
> --
> 2.3.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa at gmail.com
More information about the Openembedded-devel
mailing list