[oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit

[Paul Eggleton]

On Monday 11 May 2015 21:52:00 Martin Jansa wrote:
> On Mon, May 11, 2015 at 12:43:41PM -0700, Khem Raj wrote:
> > On Mon, May 11, 2015 at 12:00 PM, Martin Jansa <martin.jansa at gmail.com> 
wrote:
> > > RDEPENDS adds dependency only between do_package tasks for build time
> > > dependency you need do_configure depending on do_populate_sysroot
> > 
> > its do_build which will depend on do_package_write task in case of
> > RDEPENDS
> > and do_package_write task will then recurse further to build it.
> 
>         <section id='build-dependencies'>
>             <title>Build Dependencies</title>
> 
>             <para>
>                 BitBake uses the
>                 <link
> linkend='var-DEPENDS'><filename>DEPENDS</filename></link> variable to
> manage build time dependencies.
>                 The "deptask" varflag for tasks signifies the task of each
>                 item listed in <filename>DEPENDS</filename> that must
>                 complete before that task can be executed.
>                 Here is an example:
>                 <literallayout class='monospaced'>
>      do_configure[deptask] = "do_populate_sysroot"
>                 </literallayout>
>                 In this example, the
> <filename>do_populate_sysroot</filename> task of each item in
> <filename>DEPENDS</filename> must complete before
> <filename>do_configure</filename> can execute.
>             </para>
>         </section>
> 
> 
>         <section id='runtime-dependencies'>
>             <title>Runtime Dependencies</title>
> 
>             <para>
>                 BitBake uses the
>                 <link
> linkend='var-PACKAGES'><filename>PACKAGES</filename></link>, <link
> linkend='var-RDEPENDS'><filename>RDEPENDS</filename></link>, and <link
> linkend='var-RRECOMMENDS'><filename>RRECOMMENDS</filename></link> variables
> to manage runtime dependencies.
>             </para>
> 
>             <para>
>                 The <filename>PACKAGES</filename> variable lists runtime
>                 packages.
>                 Each of those packages can have
> <filename>RDEPENDS</filename> and <filename>RRECOMMENDS</filename> runtime
> dependencies. The "rdeptask" flag for tasks is used to signify the task of
> each item runtime dependency which must have completed before that task can
> be executed.
>                 <literallayout class='monospaced'>
>      do_package_qa[rdeptask] = "do_packagedata"
>                 </literallayout>
>                 In the previous example, the
> <filename>do_packagedata</filename> task of each item in
> <filename>RDEPENDS</filename> must have completed before
> <filename>do_package_qa</filename> can execute. </para>
>         </section>
> 
> 
> so again, RDEPENDS isn't good enough for build time dependencies

This is correct. Even an explicit RDEPENDS within the recipe does not add any 
dependency from do_configure on do_populate_sysroot, so if there is a build 
time dependency you definitely need DEPENDS as well.

I do agree though that the warning message needs improvement in order to be as 
clear as possible.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre