[oe] [PATCH] Adding support for directFB to mplayer2 recipe

[ROUSSILLE Hector]

I Thought the PACKAGECONFIG option was enough, well that's the answer i had on the IRC 


De: "Gary Thomas" <gary at mlbassoc.com> 
À: openembedded-devel at lists.openembedded.org 
Envoyé: Mercredi 27 Mai 2015 13:36:35 
Objet: Re: [oe] [PATCH] Adding support for directFB to mplayer2 recipe 

On 2015-05-27 05:13, Hector Roussille wrote: 
> Signed-off-by: Hector Roussille <hroussille at adeneo-embedded.com> 
> --- 
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++- 
> 1 file changed, 2 insertions(+), 1 deletion(-) 
> 
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> index 5b0e1de..b208144 100644 
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> @@ -121,6 +121,7 @@ PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc" 
> PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis" 
> PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19" 
> PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123" 
> +PACKAGECONFIG[directfb] = "--enable-directfb,--disable-directfb,directfb" 
> 
> FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math" 
> BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}" 
> @@ -134,7 +135,7 @@ do_configure() { 
> sed -i 's|/usr/\S*lib[\w/]*||g' ${S}/configure 
> sed -i 's|_install_strip="-s"|_install_strip=""|g' ${S}/configure 
> sed -i 's|HOST_CC|BUILD_CC|' ${S}/Makefile 
> - 
> + sed -i 's|extra_cflags="-I. $extra_cflags"|extra_cflags="-I. -I${STAGING_INCDIR}/directfb $extra_cflags"|g' ${S}/configure 
> export SIMPLE_TARGET_SYS="$(echo ${TARGET_SYS} | sed s:${TARGET_VENDOR}::g)" 
> ./configure ${EXTRA_OECONF} 
> 

Shouldn't this at least be conditional on directfb support in 
DISTRO_FEATURES? It won't do much good to enable it in this 
recipe if the rest of the system isn't using directfb as well. 

-- 
------------------------------------------------------------ 
Gary Thomas | Consulting for the 
MLB Associates | Embedded world 
------------------------------------------------------------ 
-- 
_______________________________________________ 
Openembedded-devel mailing list 
Openembedded-devel at lists.openembedded.org 
http://lists.openembedded.org/mailman/listinfo/openembedded-devel