[oe] [meta-java][PATCH 4/4] openjdk-8: add recipes for openjdk-8 and openjre-8

Jens Rehsack rehsack at gmail.com
Tue Nov 3 10:25:56 UTC 2015


> Am 29.10.2015 um 19:59 schrieb Otavio Salvador <otavio.salvador at ossystems.com.br>:
> 
> On Thu, Oct 29, 2015 at 4:51 PM, Richard Leitner
> <richard.leitner at skidata.com> wrote:
>> On 10/29/2015 05:03 PM, Otavio Salvador wrote:
>>> On Thu, Oct 29, 2015 at 1:49 PM, Richard Leitner
>>> <richard.leitner at skidata.com> wrote:
>>>> 
>>>> What indentation should be chosen? Tabs? Spaces (how much)?
>>>> Maybe I have also time to fix that in the recipes-core.
>>> 
>>> I would prefer 4 spaces.
>>> 
>> 
>> Generally I prefer real tabs displayed with 8 spaces width (like the
>> linux kernel coding style). But of course I will stick to the formatting
>> rules if we have one in OE layers ;-)
>> 
>> Is there a generally considered rule/advisory across all OE layers or
>> meta-java?
>> If yes, where do I find it?
>> If no, wouldn't that be a good idea? (and of course write it down!)
> 
> http://www.openembedded.org/wiki/Styleguide

I reformatted the indent to 4 spaces and renamed the patch directory.

The include files can't be reduced in a sane way, because openjdk-8 patch
provides 3 recipes at once:

* openjdk-8-native - which is provided for Java7 with recipes-core/icedtea7 instead of embedding it into recipes-core/openjdk
* openjdk-8 - provides full JDK for target (compiled j2sdk image)
* openjre-8 - provides the plain JRE (compiled j2re image)

That's a huge difference to the existing icedtea7/openjdk-7 combo, which provides 2 recipes and a dedicated package for openjdk-7-jre which contains some jdk relicts. 

So all 3 recipes includes the include file for the concrete HG URI's and checksums for the given release, then either the native or cross inc for building and they have shared code in common inc. Theoretically the URI's and checksums can be moved into common.inc - but this increases entropy in common.inc for decreasing entropy in directory, but mixing information that don't belong together.

Best regards
-- 
Jens Rehsack - rehsack at gmail.com




More information about the Openembedded-devel mailing list