[oe] [meta-multimedia][PATCH 2/3] VLC: make libnotify a configurable dependency

[Rafaël Carré]

On 05/11/2015 21:17, Martin Jansa wrote:
> On Wed, Nov 04, 2015 at 05:03:18PM +0100, Rafaël Carré wrote:
>> ---
>>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> index b989849..ad5c81d 100644
>> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>>     virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>>     tremor faad2 ffmpeg flac libxpm libxinerama fluidsynth alsa-lib \
>> -   libdvdcss libdvdread lua-native lua libidn libnotify gtk+ gnome-vfs \
>> +   libdvdcss libdvdread lua-native lua libidn gnome-vfs \
>>     libdc1394 libraw1394 avahi libjpeg-turbo xz libmodplug mpeg2dec \
>>     libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \
>>     tiff xcb-util-keysyms samba"
>> @@ -58,6 +58,7 @@ PACKAGECONFIG[gstreamer] = "--enable-gst-decode,--disable-gst-decode,gstreamer1.
>>  PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx, libvpx"
>>  PACKAGECONFIG[qt4] = "--enable-qt,--disable-qt, qt4-x11-free"
>>  PACKAGECONFIG[freerdp] = "--enable-freerdp,--disable-freerdp, freerdp"
>> +PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify gtk+"
> 
> Removing gtk+ from DEPENDS causes even more undeterministic
> dependencies:

I would guess those real dependencies were hidden by gtk+ which depends on
every single one of them.

Except maybe vorbis which was hidden by gstreamer plugins?

I agree that although depending on gtk+ is not fully nice neither
correct, it makes
things deterministic.


So I guess I should rather add all the PACKAGECONFIG for these modules
first and then move
those dependencies to their respective PACKAGECONFIG ?


How is your jenkins instance built: world first, then VLC ?

Should I check for additional automatic dependencies inside VLC or
assume that
the list below is exhaustive?

> vlc-2.2.1: vlc: configure was passed unrecognised options:
> --disable-gnome-vfs [unknown-configure-option]
> vlc-2.2.1: vlc rdepends on fontconfig, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on pixman, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on freetype, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libupnp, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on pango, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libvorbis, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on cairo, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libavc1394, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on harfbuzz, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libssh2, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on gdk-pixbuf, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on gnome-vfs, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libcroco, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on libdvdnav, but it isn't a build dependency?
> [build-deps]
> vlc-2.2.1: vlc rdepends on librsvg, but it isn't a build dependency?
> [build-deps]
> 
>>  
>>  do_configure_prepend() {
>>      cp ${STAGING_DATADIR}/libtool/config.* ${S}/autotools/ || true