[oe] [meta-oe][PATCH 1/3] samba: fix dependencies and QA issues

[Khem Raj]

> On Nov 10, 2015, at 2:00 PM, Jens Rehsack <rehsack at gmail.com> wrote:
> 
> 
>> Am 10.11.2015 um 22:42 schrieb Christopher Larson <clarson at kergoth.com>:
>> 
>> On Tue, Nov 10, 2015 at 2:22 PM, Jens Rehsack <rehsack at gmail.com> wrote:
>> 
>>> +                   ${@base_contains('DISTRO_FEATURES', 'sysvinit', 'lsb',
>>> '', d)} \
>>> 
>> 
>> This really requires lsb to able build, for all sysvinit distros? That
>> seems unlikely. Was this intended to be based on the lsb distro feature?
>> Also, why add lsb to rdepends independently of the packageconfig? I'd think
>> using the packageconfig's 4th field for rdepends, if necessary, would work
>> better, unless I'm missing something?
> 
> You do ;)
> 
> It uses the LSB init-script for systemv-init - and lsb doesn't suck in that
> much that it hurts. But the line you quoted just adds an item to PACKAGECONFIG :)
> Do a PACKAGECONFIG_remove-pn-samba = "lsb" to avoid the 4 scripts …
> 

that should be tied to ‘lsb’ distro feature as it exists. Distro’s then automatically get the intended behavior based upon the selected distro policy.



> I will be happy supporting a patch distinguishing between lsb's init-script
> and basic init-script with only rudimentary start and stop and nothing else.
> 
> Cheers
> -- 
> Jens Rehsack - rehsack at gmail.com
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel