[oe] [PATCH][meta-xfce] xfce4-session: exclude machine-host dependency with SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS

[Andreas Müller]

On Thu, Nov 12, 2015 at 5:42 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
> On Thu, Nov 12, 2015 at 05:11:36PM +0100, Andreas Müller wrote:
>> On Thu, Nov 12, 2015 at 4:56 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
>> > * this whole machine-host is very bad idea, all changes from postinst
>> >   will be removed when netbase package is upgraded (it has CONFFILES
>> >   set but most users won't know that this entry was appended by
>> >   machine-host package)
>> > * see:
>> >   http://lists.openembedded.org/pipermail/openembedded-devel/2015-September/103271.html
>> > * fixes:
>> > ERROR: xfce4-session different signature for task do_package_write_ipk.sigdata between qemux86copy and qemux86
>> > runtaskdeps changed from ['dbusdbus_1.8.20.bb.do_packagedata', 'opkg-utilsopkg-utils_git.bb.do_populate_sysroot:virtual:native', 'pseudopseudo_1.7.4.bb.do_populate_sysroot:virtual:native', 'upowerupower_0.9.14.bb.do_packagedata', 'xfce4-sessionmachine-host.bb.do_packagedata', 'xfce4-sessionxfce4-session_4.12.1.bb.do_package', 'xfce4-sessionxfce4-session_4.12.1.bb.do_packagedata', 'xorg-appiceauth_1.0.7.bb.do_packagedata', 'xorg-appxinit_1.3.4.bb.do_packagedata'] to ['dbusdbus_1.8.20.bb.do_packagedata', 'opkg-utilsopkg-utils_git.bb.do_populate_sysroot:virtual:native', 'pseudopseudo_1.7.4.bb.do_populate_sysroot:virtual:native', 'upowerupower_0.9.14.bb.do_packagedata', 'xfce4-sessionmachine-host.bb.do_packagedata', 'xfce4-sessionxfce4-session_4.12.1.bb.do_package', 'xfce4-sessionxfce4-session_4.12.1.bb.do_packagedata', 'xorg-appiceauth_1.0.7.bb.do_packagedata', 'xorg-appxinit_1.3.4.bb.do_packagedata']
>> > meta-openembedded/meta-xfce/recipes-xfce/xfce4-session/machine-host.bb.do_packagedata with hash 7b3f9a883729dfe908e17980476d10e2
>> >  changed to
>> > meta-openembedded/meta-xfce/recipes-xfce/xfce4-session/machine-host.bb.do_packagedata with hash f51309cb641c82a6d8e2dc5387bb6484
>> > Hash for dependent task xfce4-sessionmachine-host.bb.do_packagedata changed from 7b3f9a883729dfe908e17980476d10e2 to f51309cb641c82a6d8e2dc5387bb6484
>> >
>> > Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
>> > ---
>> >  meta-xfce/conf/layer.conf | 4 ++++
>> >  1 file changed, 4 insertions(+)
>> >
>> > diff --git a/meta-xfce/conf/layer.conf b/meta-xfce/conf/layer.conf
>> > index 55bcef6..64b1077 100644
>> > --- a/meta-xfce/conf/layer.conf
>> > +++ b/meta-xfce/conf/layer.conf
>> > @@ -17,3 +17,7 @@ LAYERDEPENDS_xfce-layer += "openembedded-layer"
>> >  LAYERDEPENDS_xfce-layer += "gnome-layer"
>> >  LAYERDEPENDS_xfce-layer += "openembedded-layer"
>> >  LAYERDEPENDS_xfce-layer += "meta-python"
>> > +
>> > +SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
>> > +  xfce4-session->machine-host \
>> > +"
>> > --
>> I missed that - there should be another way to go for this problem.
>> Two questions
>>
>> * What exactly does SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS do? I checked your
>> original patch in oe-core but do not understand what the result of
>> setting SIGGEN_EXCLUDE_.. is.
>
> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html#var-SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS
> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html#var-SIGGEN_EXCLUDERECIPES_ABISAFE
>
> Does this help? In short it will prevent sstate signature handler in
> including the task signatures of recipes included in these variables.
>
> SIGGEN_EXCLUDERECIPES_ABISAFE excludes it from everywhere
> SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS excludes it only when counting signature
> of given recipes.
>
>> * How much time do you give me to come around with a proper solution -
>> without machine-host quirk? I would like to avoid getting this into
>> jethro.
>
> machine-host recipe is already in jethro (released yesterday) or do you
> want to avoid this SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS addition?
The machine-host solution - introduced by me if I remember correct -
is crap (as you wrote more polite in commit message). I would like to
remove this recipe and find another solution. Because of I am not able
to tell when I can take care I suggest: Please continue as planned
before my email. As soon as I have a solution I will send patches for
master and pull-requests for jethro.

Andreas