[oe] [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr

Jens Rehsack rehsack at gmail.com
Fri Nov 13 09:38:28 UTC 2015


> Am 12.11.2015 um 21:17 schrieb Christopher Larson <kergoth at gmail.com>:
> 
> From: Christopher Larson <chris_larson at mentor.com>
> 
> These will depend on libattr if it's available, and we need deterministic
> builds. This fixes a build-deps failure which occurs when attr is built before
> them. There's currently no configuration option to explicitly control this
> dependency, and I don't know enough about waf to add such an option, so
> unconditionally dep on it for now.
> 
> Signed-off-by: Christopher Larson <chris_larson at mentor.com>
> ---
> meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
> meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
> meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> index 0b9e1f2..e349187 100644
> --- a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> +++ b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> @@ -1,6 +1,7 @@
> SUMMARY = "The tdb library"
> SECTION = "libs"
> LICENSE = "LGPL-3.0+ & GPL-3.0+"
> +DEPENDS += "attr"
> 
> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
>                     file://${COREBASE}/meta/files/common-licenses/GPL-3.0;md5=c79ff39f19dfec6d293b95dea7b07891"
> diff --git a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> index f297f30..c37eeb3 100644
> --- a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> +++ b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> @@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"
> SECTION = "libs"
> LICENSE = "LGPLv3+"
> 
> -DEPENDS += "talloc libcap"
> +DEPENDS += "talloc libcap attr"
> RDEPENDS_${PN} += "libtalloc"
> RDEPENDS_python-tevent = "python"
> 
> diff --git a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> index 89c390f..7931374 100644
> --- a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> +++ b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> @@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool system with destructors"
> HOMEPAGE = "http://talloc.samba.org"
> SECTION = "libs"
> LICENSE = "LGPL-3.0+ & GPL-3.0+"
> +DEPENDS += "attr"
> 
> SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz"
> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
> -- 
> 2.2.1

RDEPENDS is wrong for deterministic builds, since they leave a race condition open that attr is build parallel to libtevent
and 2nd build is different to first build.

If you want, I handle that better in a patchy way I discussed with JaMa yesterday in #yocto (patch check out depending on PACKAGECONFIG)

Cheers
-- 
Jens Rehsack - rehsack at gmail.com




More information about the Openembedded-devel mailing list